Repository navigation
Fix in shutdown of PGM - #537
Merged
NicolasFussberger merged 2 commits intoAug 28, 2026
Merged
NicolasFussberger merged 2 commits into
NicolasFussberger merged 2 commits into
Conversation
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
TimoSteuerwaldETAS
marked this pull request as ready for review
August 26, 2026 14:31
TimoSteuerwaldETAS
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
August 26, 2026 14:31
1 of 2 tasks
NicolasFussberger
requested changes
Aug 27, 2026
TimoSteuerwaldETAS
force-pushed
the
bugfix/crash_on_lcm_shutdown
branch
from
August 27, 2026 14:22
1e9603b to
da51411
Compare
TimoSteuerwaldETAS
had a problem deploying
to
workflow-approval
August 27, 2026 14:22 — with
GitHub Actions
Failure
TimoSteuerwaldETAS
had a problem deploying
to
workflow-approval
August 27, 2026 14:22 — with
GitHub Actions
Failure
process_monitor_ could be still used in a worker_jobs / thread_pool.
TimoSteuerwaldETAS
force-pushed
the
bugfix/crash_on_lcm_shutdown
branch
from
August 27, 2026 14:24
da51411 to
c1292a2
Compare
TimoSteuerwaldETAS
had a problem deploying
to
workflow-approval
August 27, 2026 14:24 — with
GitHub Actions
Failure
TimoSteuerwaldETAS
had a problem deploying
to
workflow-approval
August 27, 2026 14:24 — with
GitHub Actions
Failure
NicolasFussberger
approved these changes
Aug 28, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Race condition in pipeline runs during lcm shutdown, when process_monitor is still used in worker_jobs / thread_pool, which leads to failing integration tests.
For example here: https://github.com/eclipse-score/lifecycle/actions/runs/32954787452/job/98133959929?pr=530
Solution: Move process_monitor_.reset() after the reset of thread_pool / worker_jobs.