Skip to content

Document to_chars async-signal-safety assumption in signal_safe_log #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaciejKaszynski merged 1 commit into from
Sep 10, 2026
Merged

Document to_chars async-signal-safety assumption in signal_safe_log #622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions score/launch_manager/src/daemon/src/common/signal_safe_log.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ class signal_safe_buffer
}

/// @brief Append the given integer to the buffer.
/// @note std::to_chars is not guaranteed async signal safe by the C++ standard. It is
/// restricted to integral types here because, unlike floating point types (e.g.
/// libstdc++'s long double overload, which allocates), integral overloads are known not
/// to allocate or throw in the implementations we support. See
/// https://github.com/eclipse-score/lifecycle/issues/385.
template <typename T, std::enable_if_t<std::is_integral_v<T>, bool> = true>
void append(const T& value)
{
Expand Down
Loading