Repository navigation
Use name for each thread - #631
Merged
Merged
Conversation
NicolasFussberger
deployed
to
workflow-approval
September 14, 2026 06:30 — with 
GitHub Actions
Active
GitHub Actions
Active
NicolasFussberger
deployed
to
workflow-approval
September 14, 2026 06:30 — with
GitHub Actions
Active
GitHub Actions
Active
paulquiring
reviewed
Sep 14, 2026
| } | ||
| // only start thread if everything was ok | ||
| m_signal_handler_thread = std::thread(&LifeCycleManager::handle_signal, this); // LCOV_EXCL_BR_LINE | ||
| score::os::set_thread_name(m_signal_handler_thread, "lcm_signal"); |
Contributor
There was a problem hiding this comment.
lcm is needed to identify the thread because it is part of application process.
paulquiring
approved these changes
Sep 14, 2026
NicolasFussberger
marked this pull request as ready for review
September 14, 2026 08:11
NicolasFussberger
requested review from
FScholPer,
MaciejKaszynski,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
September 14, 2026 08:11
MaciejKaszynski
approved these changes
Sep 14, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in LCM - Lifecycle & Health FT
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each thread shall be given a name:
ThreadPool -> "worker"
Alive Monitoring Thread -> "health_mon"
Os Handler -> "os_handler"
mw::lifecylce signal handlign -> "lcm_signal"
The controlclient thread is intentionally left out, as this complete implementation is about to be removed.