Skip to content

Rename "fallback" to "fallback_run_target" - #742

Merged
NicolasFussberger merged 4 commits into
eclipse-score:mainfrom
etas-contrib:fallback_run_target
Oct 8, 2026
Merged

Rename "fallback" to "fallback_run_target"#742
NicolasFussberger merged 4 commits into
eclipse-score:mainfrom
etas-contrib:fallback_run_target

Conversation

@NicolasFussberger

@NicolasFussberger NicolasFussberger commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rationale:

  • This name is known to users from the configuration, they will understand the logs
  • This name is already reserved and checked, so naming collisions with user-defined RunTargets are not possible

Resolves: #694

@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 08:47 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 08:47 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 08:47 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 08:47 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 10:10 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 10:10 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 10:10 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 10:10 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 11:34 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 11:34 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 11:34 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval October 5, 2026 11:34 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger marked this pull request as ready for review October 5, 2026 12:03
danth
danth reviewed Oct 5, 2026
View reviewed changes

@danth danth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although there are some more files which have the old name :))

MaciejKaszynski
MaciejKaszynski reviewed Oct 6, 2026
View reviewed changes

@MaciejKaszynski MaciejKaszynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we could add some note in the docs about the fallback and if it's allowed to be switched to?

@NicolasFussberger

NicolasFussberger commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Do you think we could add some note in the docs about the fallback and if it's allowed to be switched to?

I think we would need to make some changes first.
I think it should be possible to transition to this run target, otherwise you have to redefine the same run target in the "run_targets" list if you want to use it.
However, currently the code determines the RunTarget activation reason that is returned to SM based on the name. So manually transitioning to this run target would lead to unintended behaviour.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-742: https://eclipse-score.github.io/lifecycle/pr-742/

@NicolasFussberger

NicolasFussberger commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Looks good, although there are some more files which have the old name :))

Thanks, should be fixed now

@NicolasFussberger
NicolasFussberger added this pull request to the merge queue Oct 8, 2026
Merged via the queue into eclipse-score:main with commit 59f6e53 Oct 8, 2026
21 of 27 checks passed
@NicolasFussberger
NicolasFussberger deleted the fallback_run_target branch October 8, 2026 12:51

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — d600a335 Waiting Oct 7, 2026 by NicolasFussberger via Build and test x86_64-qnx / approval #1287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaciejKaszynski MaciejKaszynski MaciejKaszynski approved these changes
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner
+1 more reviewer
@danth danth danth approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Interaction between fallback_run_target and run_targets is undefined

3 participants

@NicolasFussberger @danth @MaciejKaszynski