Skip to content

Coverage for lifecycle_client [2/N]: Add unit tests for report_running_impl.cpp - #757

Merged
MaciejKaszynski merged 12 commits into
eclipse-score:mainfrom
etas-contrib:feature/lifecycle_client_coverage_2
Oct 13, 2026
Merged

Coverage for lifecycle_client [2/N]: Add unit tests for report_running_impl.cpp#757
MaciejKaszynski merged 12 commits into
eclipse-score:mainfrom
etas-contrib:feature/lifecycle_client_coverage_2

Conversation

@cameron-craig-etas

@cameron-craig-etas cameron-craig-etas commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

#686

  • This PR introduces unit test for report_running_impl.cpp.
  • We make use of the existing syscall mocks
  • 100% code coverage has been reached for this file.
  • These test use the suggested Given...Expected...When...Then pattern.
image

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-757: https://eclipse-score.github.io/lifecycle/pr-757/

@cameron-craig-etas
cameron-craig-etas marked this pull request as ready for review October 7, 2026 12:22
MaciejKaszynski
MaciejKaszynski requested changes Oct 7, 2026
View reviewed changes
Comment thread score/launch_manager/src/lifecycle_client/src/details/BUILD Outdated
Comment thread tests/utils/accessors/BUILD
Comment thread score/launch_manager/src/lifecycle_client/src/details/report_running_impl_UT.cpp Outdated
@cameron-craig-etas
cameron-craig-etas force-pushed the feature/lifecycle_client_coverage_2 branch from dfdd38c to 4a3532a Compare October 8, 2026 09:14
@cameron-craig-etas
cameron-craig-etas force-pushed the feature/lifecycle_client_coverage_2 branch from 4a3532a to 934ce93 Compare October 9, 2026 09:42
@cameron-craig-etas
cameron-craig-etas force-pushed the feature/lifecycle_client_coverage_2 branch from 934ce93 to 9d59ed7 Compare October 12, 2026 07:07
MaciejKaszynski
MaciejKaszynski requested changes Oct 12, 2026
View reviewed changes

@MaciejKaszynski MaciejKaszynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just should delete the unused accessor

Comment thread score/launch_manager/src/lifecycle_client/src/details/report_running_impl_UT.cpp
@MaciejKaszynski
MaciejKaszynski added this pull request to the merge queue Oct 13, 2026
Merged via the queue into eclipse-score:main with commit 51d3b1c Oct 13, 2026
12 of 16 checks passed
@MaciejKaszynski
MaciejKaszynski deleted the feature/lifecycle_client_coverage_2 branch October 13, 2026 07:26
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Oct 13, 2026

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — fe000e3b Waiting Oct 12, 2026 by cameron-craig-etas via Build and test x86_64-qnx / approval #1383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaciejKaszynski MaciejKaszynski MaciejKaszynski approved these changes
@NicolasFussberger NicolasFussberger Awaiting requested review from NicolasFussberger NicolasFussberger is a code owner
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner

Assignees

No one assigned

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cameron-craig-etas @MaciejKaszynski