Skip to content

Coverage for lifecycle_client [4/N]: Add unit tests for lifecycle.rs - #759

Merged
MaciejKaszynski merged 2 commits into
eclipse-score:mainfrom
etas-contrib:feature/lifecycle_client_coverage_4
Oct 8, 2026
Merged

Coverage for lifecycle_client [4/N]: Add unit tests for lifecycle.rs#759
MaciejKaszynski merged 2 commits into
eclipse-score:mainfrom
etas-contrib:feature/lifecycle_client_coverage_4

Conversation

@cameron-craig-etas

@cameron-craig-etas cameron-craig-etas commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

#686

  • Adds a single unit test to cover the Rust report_running API
  • Fixes an incorrect return type in the Rust API
  • Given that the Rust API just calls the C API directly, I see no need to test any further.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-759: https://eclipse-score.github.io/lifecycle/pr-759/

@cameron-craig-etas
cameron-craig-etas marked this pull request as ready for review October 8, 2026 11:02
@MaciejKaszynski
MaciejKaszynski added this pull request to the merge queue Oct 8, 2026
Merged via the queue into eclipse-score:main with commit 07bab43 Oct 8, 2026
12 of 16 checks passed
@MaciejKaszynski
MaciejKaszynski deleted the feature/lifecycle_client_coverage_4 branch October 8, 2026 15:38

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — a608413d Waiting Oct 7, 2026 by cameron-craig-etas via Build and test x86_64-qnx / approval #1292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaciejKaszynski MaciejKaszynski MaciejKaszynski approved these changes
@NicolasFussberger NicolasFussberger Awaiting requested review from NicolasFussberger NicolasFussberger is a code owner
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner

Assignees

No one assigned

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cameron-craig-etas @MaciejKaszynski