Skip to content

Add yaml line length limit - #760

Merged
MaciejKaszynski merged 2 commits into
eclipse-score:mainfrom
etas-contrib:feature/yaml-line-length
Oct 8, 2026
Merged

Add yaml line length limit#760
MaciejKaszynski merged 2 commits into
eclipse-score:mainfrom
etas-contrib:feature/yaml-line-length

Conversation

@cameron-craig-etas

@cameron-craig-etas cameron-craig-etas commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

#686

There's currently no line length limit for yaml file. This causes long strings to become unreadable, as they are reformatted onto one long line. We now set the line length limit to 120 characters, to match the c++ column limit in .clang-format.

I noticed this while making an update to coverage_justifications.yaml, for another PR.

@cameron-craig-etas
cameron-craig-etas marked this pull request as ready for review October 7, 2026 14:36
danth
danth reviewed Oct 7, 2026
View reviewed changes
Comment thread .github/workflows/on-pr.yml Outdated
@MaciejKaszynski
MaciejKaszynski added this pull request to the merge queue Oct 8, 2026
Merged via the queue into eclipse-score:main with commit 731823a Oct 8, 2026
12 of 16 checks passed
@MaciejKaszynski
MaciejKaszynski deleted the feature/yaml-line-length branch October 8, 2026 07:52

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — 3a23472b Waiting Oct 8, 2026 by cameron-craig-etas via Build and test unit-tests-arm64-qnx / approval #1307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaciejKaszynski MaciejKaszynski MaciejKaszynski approved these changes
@NicolasFussberger NicolasFussberger Awaiting requested review from NicolasFussberger NicolasFussberger is a code owner
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner
+1 more reviewer
@danth danth danth left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cameron-craig-etas @danth @MaciejKaszynski