Repository navigation
fix(launch_manager): report kRecoveryAction from recovery, not name - #773
Merged
NicolasFussberger merged 2 commits intoOct 13, 2026
Merged
NicolasFussberger merged 2 commits into
NicolasFussberger merged 2 commits into
Conversation
finalizeTransitionSuccess() decided the activation source by comparing
the reached Run Target with Graph::recovery_state_name
("fallback_run_target"). An explicit State Manager request for that
Run Target (accepted by ControlProvider, since the name exists) was
therefore reported as kRecoveryAction although nothing had failed.
Carry the origin with the transition instead: setPendingState() and
startTransition() take an is_recovery flag (default false), set only on
the recovery paths in ProcessGroupManager (handleRecoveryRequest and the
undefined-state fallback in processGroupHandler), and the source is
derived from that flag. A recovery is still reported as kRecoveryAction,
so fallback_to_same_target_restarts is unchanged.
Add graph_UT cases for both origins and for the flag not leaking into
the next transition, and an explicit_fallback_request integration test
that fails without this change (fallback reported as kRecoveryAction).
Signed-off-by: hskang <amelia@ivis.ai>
hskang-amelia
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
October 9, 2026 12:55
hskang-amelia
requested a deployment
to
workflow-approval
October 9, 2026 12:55 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
hskang-amelia
requested a deployment
to
workflow-approval
October 9, 2026 12:55 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
hskang-amelia
requested a deployment
to
workflow-approval
October 9, 2026 12:55 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
hskang-amelia
requested a deployment
to
workflow-approval
October 9, 2026 12:55 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
danth
suggested changes
Oct 9, 2026
danth
left a comment
danth
left a comment
Member
There was a problem hiding this comment.
Nice catch :))
I have some suggestions about the implementation.
Address review on eclipse-score#773: - startTransition() and setPendingState() take a RunTargetActivationSource instead of a bool is_recovery. - The pending Run Target and its source are kept together in a PendingTransition struct; isPendingRecovery() is replaced by getPendingTransition(). - explicit_fallback_request no longer switches back to Startup; only the explicit fallback_run_target activation is checked. Signed-off-by: hskang <amelia@ivis.ai>
danth
approved these changes
Oct 12, 2026
NicolasFussberger
approved these changes
Oct 13, 2026
Merged
via the queue into
eclipse-score:main
with commit Oct 13, 2026
da699f3
18 of 20 checks passed
github-project-automation
Bot
moved this from Backlog
to Done
in LCM - Lifecycle & Health FT
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finalizeTransitionSuccess() decided the activation source by comparing the reached Run Target with Graph::recovery_state_name ("fallback_run_target"). An explicit State Manager request for that Run Target (accepted by ControlProvider, since the name exists) was therefore reported as kRecoveryAction although nothing had failed.
Carry the origin with the transition instead: setPendingState() and startTransition() take an is_recovery flag (default false), set only on the recovery paths in ProcessGroupManager (handleRecoveryRequest and the undefined-state fallback in processGroupHandler), and the source is derived from that flag. A recovery is still reported as kRecoveryAction, so fallback_to_same_target_restarts is unchanged.
Add graph_UT cases for both origins and for the flag not leaking into the next transition, and an explicit_fallback_request integration test that fails without this change (fallback reported as kRecoveryAction).