Repository navigation
OShandler improvement - #786
Merged
Merged
Conversation
NicolasFussberger
requested a deployment
to
workflow-approval
October 14, 2026 09:12 — with
GitHub Actions
Waiting
NicolasFussberger
requested a deployment
to
workflow-approval
October 14, 2026 09:12 — with
GitHub Actions
Waiting
NicolasFussberger
requested a deployment
to
workflow-approval
October 14, 2026 09:12 — with
GitHub Actions
Waiting
NicolasFussberger
requested a deployment
to
workflow-approval
October 14, 2026 09:12 — with
GitHub Actions
Waiting
2 tasks
danth
approved these changes
Oct 14, 2026
danth
left a comment
Member
There was a problem hiding this comment.
Changes look good.
I wonder if the OSHandler logs should be info level rather than debug
Contributor
Author
There is already the log in the Process Info Node with the actual process name, mentioning only the general status code. Ideally the logs would come from the process info node, but that would require more change to forward this information and I am not sure if this same information is available in the future when supporting daemonized processes. |
NicolasFussberger
force-pushed
the
fix_oshandler
branch
from
October 15, 2026 07:00
6e1ce7f to
8dfa465
Compare
NicolasFussberger
marked this pull request as ready for review
October 15, 2026 07:00
NicolasFussberger
requested review from
FScholPer,
MaciejKaszynski,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
October 15, 2026 07:00
Contributor
|
Documentation preview for this pull request is available at: |
anmittag
approved these changes
Oct 15, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 15, 2026
Merged
via the queue into
eclipse-score:main
with commit Oct 15, 2026
f8dcabb
35 of 39 checks passed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change add the following improvements:
Further follow up could be:
Resolves: #750