Skip to content

OShandler improvement - #786

Merged
MaciejKaszynski merged 1 commit into
eclipse-score:mainfrom
etas-contrib:fix_oshandler
Oct 15, 2026
Merged

MaciejKaszynski merged 1 commit into
eclipse-score:mainfrom
etas-contrib:fix_oshandler

Conversation

@NicolasFussberger

@NicolasFussberger NicolasFussberger commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Change add the following improvements:

  • OSHandler ignores STOPPED and CONTINUE signals for child processes and does not treat them as termination
  • OSHandler logs the actual reason for termination: Process terminated with exit code or Process killed by specific signal
  • ProcessInfoNode does not log the status as "exit code" but refers to it just as status

Further follow up could be:

  • Store not only the raw status, but the termination reason in safe process map and forward this to the ProcessInfoNode

Resolves: #750

@danth danth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

I wonder if the OSHandler logs should be info level rather than debug

@NicolasFussberger

Copy link
Copy Markdown
Contributor Author

Changes look good.

I wonder if the OSHandler logs should be info level rather than debug

There is already the log in the Process Info Node with the actual process name, mentioning only the general status code.
I thought logging this as warn/error would seem redundant in the log.

Ideally the logs would come from the process info node, but that would require more change to forward this information and I am not sure if this same information is available in the future when supporting daemonized processes.

@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-786: https://eclipse-score.github.io/lifecycle/pr-786/

@MaciejKaszynski
MaciejKaszynski added this pull request to the merge queue Oct 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 15, 2026
@MaciejKaszynski
MaciejKaszynski added this pull request to the merge queue Oct 15, 2026
Merged via the queue into eclipse-score:main with commit f8dcabb Oct 15, 2026
35 of 39 checks passed
@MaciejKaszynski
MaciejKaszynski deleted the fix_oshandler branch October 15, 2026 13:31
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Oct 15, 2026

This branch was successfully deployed

1 active deployment
workflow-approval — 8dfa465f Deployed Oct 15, 2026 by NicolasFussberger via Build and test unit-tests-arm64-qnx / approval #1470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Process exit codes are logged incorrectly

4 participants