[WilliamRoebuck]

100% coverage for alive worker factory (working towards #712) making use of new "injection mocks". These require separate Bazel targets to link the SUT to the mock behaviour. This is needed because the methods under test construct the object within. There is no way to inject mocks with function parameters.
There might be a better way to design this class so that we don't need these mocks, but I investigated this and couldn't work out a solution that kept the same functionality. Any suggestions on this are welcome.
I'd like to add some docs about this kind of mock but I'm not sure where it should go as they're in a few different directories.
I added one new interface and renamed mock_irecovery_client to mock_recovery_client for consistency with other names.

[github-actions]

Documentation preview for this pull request is available at:
pr-799: https://eclipse-score.github.io/lifecycle/pr-799/

[Rutuja-Patil-Bosch]

@WilliamRoebuck : I have created PR #776 which contains UT cases for AliveWorkerFactory .

I noticed that this PR was created after my PR. Could you please review my PR and let me know if the existing test coverage addresses the requirements of this issue, or if any additional test cases are still needed?

I was hoping to check whether the existing coverage might already address these coverage, and would appreciate your guidance on any additional gaps to mentioned PR.

[MaciejKaszynski]

@WilliamRoebuck : I have created PR #776 which contains UT cases for AliveWorkerFactory .

I noticed that this PR was created after my PR. Could you please review my PR and let me know if the existing test coverage addresses the requirements of this issue, or if any additional test cases are still needed?

I was hoping to check whether the existing coverage might already address these coverage, and would appreciate your guidance on any additional gaps to mentioned PR.

Both #799 and #776 achieves 100% on AliveWorkerFactory.

• AliveWorkerFactory unit tests #799 introduces new interfaces for easier mocking.
  • (+) AliveWorkerFactory unit tests #799 this is more inline with score's chosen strategy of using dependency injection for mocking.
• test: Add UT for Alive Supervision #776 uses overriding new and delete to throw exceptions, AliveWorkerFactory unit tests #799 creates mocks that use linker replacement which then can use gtest to throw exceptions.
  • (+) AliveWorkerFactory unit tests #799 I would say linker replacement mocks are cleaner in this case as it makes it more reusables for the future.

766 achieves coverage on other targets so I think we should take the coverage from AliveWorkerFactory from #799 and continue with other coverage from #766