[cameron-craig-etas]

#683

When building score/lifecycle with the "all warnings" configuration, we get a narrowing warning with number_of_attempts. This unsigned integer is stored in the flatbuffer as 32-bit, but narrowed to 8-bit when used. It makes sense to have a consistent sized type so we are now storing it in the flatbuffer as 8-bit. Some tests have been added where missing.

The valid values range form 0 to 255. Note that 255 is the maximum value of uint8_t.

Command to reproduce:

bazel build //score/launch_manager --config=x86_64-linux --features=all_wall_warnings

[danth]

I think limiting it to 8 bits is fine - I can't think of a case where you would want more than 254 attempts that couldn't be solved by just having a longer wait time between them.

[NicolasFussberger]

Looks much simpler now, thanks for the refactor.

[github-actions]

Documentation preview for this pull request is available at:
pr-802: https://eclipse-score.github.io/lifecycle/pr-802/