Repository navigation
Use baselibs semaphore monotonic wait instead of polling semaphore - #811
Merged
Merged
Conversation
Contributor
|
Documentation preview for this pull request is available at: |
NicolasFussberger
marked this pull request as ready for review
October 19, 2026 07:28
NicolasFussberger
requested review from
FScholPer,
MaciejKaszynski,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
October 19, 2026 07:28
MaciejKaszynski
approved these changes
Oct 20, 2026
MaciejKaszynski
left a comment
MaciejKaszynski
left a comment
Contributor
There was a problem hiding this comment.
Looks good, didn't know about score::os::MockGuard looks really useful
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
SimonKozik
approved these changes
Oct 20, 2026
SimonKozik
left a comment
SimonKozik
left a comment
Contributor
There was a problem hiding this comment.
Changes looks OK, but I would expect better API from score::os::Semaphore...
The need to handle EINTR by hand is disappointing.
github-project-automation
Bot
moved this from Backlog
to Done
in LCM - Lifecycle & Health FT
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance Improvement: High frequency polling of semaphores likely causes high CPU load.
Instead use a single monotonic wait, provided by baselibs OSAL layer.