Repository navigation
Mark Alive shared memory exclusive - #822
Merged
Merged
Conversation
Contributor
|
Documentation preview for this pull request is available at: |
NicolasFussberger
marked this pull request as ready for review
October 20, 2026 12:19
NicolasFussberger
requested review from
FScholPer,
MaciejKaszynski,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
October 20, 2026 12:19
MaciejKaszynski
approved these changes
Oct 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 21, 2026
Merged
via the queue into
eclipse-score:main
with commit Oct 21, 2026
c5d8cd1
28 of 29 checks passed
github-project-automation
Bot
moved this from Backlog
to Done
in LCM - Lifecycle & Health FT
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a theoretical security and FFI issue when tolerating to open a preexisting shared memory which may have been created by something else.
This case should not exist in normal operation as the memory is first unlinked if it already existed.
But still there is a theoretical time period where an attacker could create the shared memory in the time btw. unlinking and shm_open.
shm_open with O_EXCL will fail in this case if the shared memory already exists.