Skip to content

Fix narrowing bug in TimeRange - #827

Merged
MaciejKaszynski merged 4 commits into
eclipse-score:mainfrom
etas-contrib:fix/time-range-narrowing
Oct 26, 2026
Merged

Fix narrowing bug in TimeRange#827
MaciejKaszynski merged 4 commits into
eclipse-score:mainfrom
etas-contrib:fix/time-range-narrowing

Conversation

@cameron-craig-etas

@cameron-craig-etas cameron-craig-etas commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

#683

  • This addresses a potentially unsafe narrowing of the min and max duration in TimeRange.
  • Checks have been added to the constructor to prevent integer overflow.
  • Tests have been added to validate expected behavior.

@github-actions

github-actions Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-827: https://eclipse-score.github.io/lifecycle/pr-827/

@cameron-craig-etas
cameron-craig-etas marked this pull request as ready for review October 20, 2026 13:00
MaciejKaszynski
MaciejKaszynski requested changes Oct 21, 2026
View reviewed changes
Comment thread score/health_monitor/src/cpp/common.h Outdated
Comment thread score/health_monitor/src/cpp/common.h Outdated
@MaciejKaszynski
MaciejKaszynski added this pull request to the merge queue Oct 26, 2026
Merged via the queue into eclipse-score:main with commit c3e7f8f Oct 26, 2026
13 of 17 checks passed
@MaciejKaszynski
MaciejKaszynski deleted the fix/time-range-narrowing branch October 26, 2026 10:07
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Oct 26, 2026

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — 73f17bad Waiting Oct 26, 2026 by cameron-craig-etas via Build and test x86_64-qnx / approval #1757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaciejKaszynski MaciejKaszynski MaciejKaszynski approved these changes
@NicolasFussberger NicolasFussberger Awaiting requested review from NicolasFussberger NicolasFussberger is a code owner
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner

Assignees

No one assigned

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cameron-craig-etas @MaciejKaszynski