Missleading/Outdated comment in data router #366

Description

When studying the code of data_router.cpp, I identified a comment which does not match the implementation:
In NewSourceSessionImpl, lines 148-153:

    std::lock_guard<std::mutex> lock(subscriber_mutex_);

    // Insert is protected by subscriber_mutex_ held by caller (new_source_session_impl).
    // This relies on the calling convention that SourceSession is only constructed
    // from new_source_session_impl() which acquires the lock before construction.
    std::ignore = sources_.insert(source_session.get());

Problem notifications

Bug has no functional impact. No urgent problem notification required.

Analysis results

Obviously, the mutex is not held by the caller.
The comment refers to functions in snake case which may have been used in legacy version.

Solution

Remove the comment.

Error Occurrence Rate

No response

How to reproduce

No response

Supporting Information

No response

Classification

Minor

First Affected Release

No response

Last Affected Release

No response

Expected Fixed Release

No response

Category

• Safety Relevant
• Security Relevant