Repository navigation
docs: Adds DR-002 for DLT network transport - #299
Conversation
ab3966a to
3519466
Compare
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
dc0d587 to
d251993
Compare
d251993 to
65152c0
Compare
65152c0 to
c98d612
Compare
c98d612 to
0953825
Compare
|
Few questions
|
| network stack, shared with all other networked services. | ||
|
|
||
| A second, feature-flagged client backend (`shm_dma_enabled`) | ||
| would allow forwarding of records through a GTL client into a |
There was a problem hiding this comment.
I think it would be nice to add all the acronyms to a glossary.
There was a problem hiding this comment.
Added in the puml file
| ' SPDX-License-Identifier: Apache-2.0 | ||
| ' ******************************************************************************* | ||
|
|
||
| @startuml network_stack_plugin |
There was a problem hiding this comment.
I think the diagram and text don't make the plugin approach clear, do you think we could add a dummy block for the datarouter to make this clear?
| gtl -r-> shmpayload | ||
| gtl -r-> shmmeta | ||
| gtl -r-> shmctrl | ||
| mwlog -r-> ctrlchannel |
There was a problem hiding this comment.
Is this a signal that there is messages in the shared memory? Might be good to label the edge to make this clear
There was a problem hiding this comment.
The shm is the interface. Each interface is clearly as R/O OR R/W. The purpose of the ctrl channel is to co-ordinate the R/W of the records through the other interface.
There was a problem hiding this comment.
three separate interfaces: metadata, payload and control
| interface "shm\n(control block)" as shmctrl | ||
| interface "DLT QNX\nControl Channel" as ctrlchannel | ||
|
|
||
| gtl -r-> shmpayload |
There was a problem hiding this comment.
We would later define a format for these log messages, is that right?
After meeting:
|
0953825 to
c050285
Compare
- GTL adpotion - DLTv2 seam support - DLT header construction/transmission into a dedicated network-stack module
c050285 to
bf13827
Compare
- Adds dlt wire format selection seam - Shows how log records are forwarded to GTL backend via GTL - Fix mw::diag interface and shows an independant component translating diag commands via DLT qnx control channel - Added legend
bf13827 to
6750b80
Compare
bb5739e to
a0fdb73
Compare
|
looks better now! |
Rendered page: https://eclipse-score.github.io/logging/pr-299/features/logging/architecture/DR-002-dlt-network-transport.html
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #