Rework of component requirements related to snapshots by tizava · Pull Request #337 · eclipse-score/persistency

tizava · 2026-07-10T11:24:14Z

Snapshots are now explicit (Driven by the users)
Snapshots are created from live data (Not from data flushed to disk)
New API to acquire status of the snapshot slot (Occupied/Free)
General rework and cleanup

github-actions · 2026-07-10T11:25:04Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 3769d5ea-b0a1-47ee-9bbe-03cf44856551
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (74 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (145 packages loaded, 1915 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3134 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3134 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3134 targets configured)

Analyzing: target //:license-check (159 packages loaded, 5223 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7699 targets configured)

Analyzing: target //:license-check (171 packages loaded, 9385 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9399 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9399 targets configured)

Analyzing: target //:license-check (175 packages loaded, 11287 targets configured)

Analyzing: target //:license-check (175 packages loaded, 11287 targets configured)

Analyzing: target //:license-check (177 packages loaded, 11537 targets configured)

INFO: Analyzed target //:license-check (177 packages loaded, 11537 targets configured).
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 66 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[15 / 17] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 33.351s, Critical Path: 2.42s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

PandaeDo

Please have a look again on the requirements. It seems to me that they are not fully atomic. You can use https://eclipse-score.github.io/process_description//main/process_areas/requirements_engineering/guidance/requirements_templates.html#gd_temp__req_formulation and also the question if the requirement is testable. Understandable they are.

anmittag · 2026-07-21T11:46:52Z

@tizava there are checks failing, please adapt and review comments. please care

PandaeDo

My findings are solved

umaucher · 2026-07-30T11:38:57Z

   :version: 1
+   :derived_from: feat_req__persistency__snapshot_create[version==1]
   :belongs_to: comp__persistency_kvs[version==1]
   :tags: inspected


changed / new requirements needs to be tagged as valid

Fixed with last commit

Requirements fixes

…sues

github-actions · 2026-08-26T12:20:30Z

The created documentation from the pull request is available at: docu-html

Ahmed-Elsaka-JC · 2026-08-31T08:40:46Z


+   .. note::
+
+      This requirement is invalid after change of snapshot handling (see <ticket-id>)


where is ticket-id ?

Ahmed-Elsaka-JC · 2026-08-31T08:41:10Z


+   .. note::
+
+      This requirement is invalid after change of snapshot handling (see <ticket-id>)


ticket-id ?

Rework of component requirements related to snapshots

6f0a23a

tizava requested review from PandaeDo, antonkri, umaucher and vinodreddy-g as code owners July 10, 2026 11:24

PandaeDo requested changes Jul 10, 2026

View reviewed changes

Comment thread score/kvs/docs/requirements/index.rst Outdated

anmittag added this to PER - Persistency FT Jul 21, 2026

github-project-automation Bot moved this to Backlog in PER - Persistency FT Jul 21, 2026

anmittag assigned tizava Jul 21, 2026

Review findings

1d92ade

tizava had a problem deploying to workflow-approval July 28, 2026 11:11 — with GitHub Actions Failure

tizava added 2 commits July 28, 2026 13:17

Merge branch 'main' into snapshot-comp-req-rework

c22b5bc

Add required attributes

fe26304

tizava had a problem deploying to workflow-approval July 28, 2026 11:22 — with GitHub Actions Failure

Make the API requirements atomic

cedb55d

tizava had a problem deploying to workflow-approval July 28, 2026 11:55 — with GitHub Actions Failure

Fix problem with long requirement name

57ead8d

tizava had a problem deploying to workflow-approval July 28, 2026 14:28 — with GitHub Actions Failure

umaucher requested changes Jul 30, 2026

View reviewed changes

Comment thread score/kvs/docs/requirements/index.rst

PandaeDo previously approved these changes Jul 30, 2026

View reviewed changes

umaucher reviewed Jul 30, 2026

View reviewed changes

Merge branch 'main' into snapshot-comp-req-rework

779df9d

tizava deployed to workflow-approval July 31, 2026 13:08 — with GitHub Actions Active

Review findings. Reset "inspected` tag and add error handling for APIs

68b6f98

tizava dismissed PandaeDo’s stale review via 68b6f98 July 31, 2026 13:37

tizava temporarily deployed to workflow-approval July 31, 2026 13:37 — with GitHub Actions Inactive

umaucher requested changes Aug 6, 2026

View reviewed changes

Comment thread score/kvs/docs/requirements/index.rst Outdated

Comment thread score/kvs/docs/requirements/index.rst

AnnaPaolaMusio and others added 2 commits August 6, 2026 15:50

fixed comment

485cd83

Merge pull request #2 from etas-contrib/snapshot-comp-req-rework-2

14a6301

Requirements fixes

tizava had a problem deploying to workflow-approval August 26, 2026 12:00 — with GitHub Actions Failure

Merge branch 'main' into snapshot-comp-req-rework & Fix docu build is…

45ba4eb

…sues

tizava deployed to workflow-approval August 26, 2026 12:11 — with GitHub Actions Active

Ahmed-Elsaka-JC reviewed Sep 17, 2026

View reviewed changes

Ahmed-Elsaka-JC reviewed Sep 18, 2026

View reviewed changes

Comment thread score/kvs/docs/requirements/index.rst Outdated

Review findings

4411cef

tizava had a problem deploying to workflow-approval September 23, 2026 11:45 — with GitHub Actions Error

Merge branch 'main' into snapshot-comp-req-rework

746021b

tizava deployed to workflow-approval September 23, 2026 11:47 — with GitHub Actions Active

tizava requested a review from umaucher September 23, 2026 11:51

umaucher approved these changes Sep 24, 2026

View reviewed changes

umaucher added this pull request to the merge queue Sep 24, 2026

Merged via the queue into eclipse-score:main with commit 0271ee7 Sep 24, 2026
27 of 28 checks passed

github-project-automation Bot moved this from Backlog to Done in PER - Persistency FT Sep 24, 2026


		.. note::

		This requirement is invalid after change of snapshot handling (see <ticket-id>)

Conversation

tizava commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

PandaeDo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anmittag commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

PandaeDo left a comment

Choose a reason for hiding this comment

Uh oh!

umaucher Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

tizava Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 26, 2026

Uh oh!

Ahmed-Elsaka-JC Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

Ahmed-Elsaka-JC Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions Bot commented Jul 10, 2026 •

edited

Loading

anmittag commented Jul 21, 2026 •

edited

Loading