Repository navigation
rollback googletest - #415
Merged
umaucher merged 2 commits intoSep 10, 2026
Merged
Conversation
Ahmed-Elsaka-JC
commented
Sep 10, 2026
Contributor
- rollback googletest version to be compatible with baselibs
- rollback googletest version to be compatible with baselibs
Ahmed-Elsaka-JC
requested review from
PandaeDo,
antonkri,
umaucher and
vinodreddy-g
as code owners
September 10, 2026 08:54
Ahmed-Elsaka-JC
had a problem deploying
to
workflow-approval
September 10, 2026 08:54 — with
GitHub Actions
Error
Ahmed-Elsaka-JC
had a problem deploying
to
workflow-approval
September 10, 2026 08:54 — with
GitHub Actions
Error
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Ahmed-Elsaka-JC
had a problem deploying
to
workflow-approval
September 10, 2026 09:03 — with
GitHub Actions
Error
Ahmed-Elsaka-JC
had a problem deploying
to
workflow-approval
September 10, 2026 09:03 — with
GitHub Actions
Error
Ahmed-Elsaka-JC
force-pushed
the
afe_googletest_rollback
branch
from
September 10, 2026 09:07
c32a7c0 to
d2913f2
Compare
Contributor
|
The created documentation from the pull request is available at: docu-html |
umaucher
reviewed
Sep 10, 2026
| bazel_dep(name = "buildifier_prebuilt", version = "8.5.1.3", dev_dependency = True) | ||
| bazel_dep(name = "google_benchmark", version = "1.9.5", dev_dependency = True) | ||
| bazel_dep(name = "googletest", version = "1.18.0", dev_dependency = True) | ||
| bazel_dep(name = "googletest", version = "1.17.0.bcr.2", dev_dependency = True) |
Contributor
There was a problem hiding this comment.
remove the dev_depencency as well to avoid the need of https://github.com/eclipse-score/reference_integration/blob/main/patches/persistency/005-googletest-not-dev-dependency.patch
Contributor
There was a problem hiding this comment.
... actually thinking about it indeed it is strange to not define it as dev_dependency ... needs to be discussed with the reference_integration team if it is not a specific problem only there but not for a "normal" app use case
umaucher
approved these changes
Sep 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.