update component requirements. by Ahmed-Elsaka-JC · Pull Request #443 · eclipse-score/persistency

Ahmed-Elsaka-JC · 2026-09-25T12:50:55Z

update component requirements

github-actions · 2026-09-25T12:51:48Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: 7856053e-ea46-42b0-b22d-e12e16a2cdb5
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (88 packages loaded, 14 targets configured)

Analyzing: target //:license-check (143 packages loaded, 3234 targets configured)

Analyzing: target //:license-check (143 packages loaded, 3234 targets configured)

Analyzing: target //:license-check (147 packages loaded, 3243 targets configured)

Analyzing: target //:license-check (159 packages loaded, 9656 targets configured)

Analyzing: target //:license-check (162 packages loaded, 9666 targets configured)

Analyzing: target //:license-check (163 packages loaded, 9790 targets configured)

INFO: Analyzed target //:license-check (168 packages loaded, 15897 targets configured).
[6 / 14] checking cached actions
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 50 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] [Prepa] Building license.check.license_check.jar ()
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 20.860s, Critical Path: 2.58s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
[main] INFO Querying Eclipse Foundation for license data for 42 items.
[main] INFO Found 32 items.
[main] INFO Querying ClearlyDefined for license data for 10 items.
[main] INFO Found 10 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO crate/cratesio/-/lazy_static/1.5.1
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.

PandaeDo · 2026-09-30T04:59:36Z

-.. comp_req:: Callback Support
-   :id: comp_req__kvs__callback_support
+.. comp_req:: Default Value Config tool validation
+   :id: comp_req__kvs__default_value_cfg_tool_validation


Suggested change

:id: comp_req__kvs__default_value_cfg_tool_validation

:id: comp_req__kvs__default_value_cfg_tool_vali

Id is too long

i would change it to : comp_req__kvs__storage_tool

PandaeDo · 2026-09-30T05:04:03Z

+   :id: comp_req__kvs__multi_instance
+   :reqtype: Functional
+   :security: NO
+   :safety: ASIL_B


It's derived from an QM requirement. So you might check if this is also an QM requirement.

thanks for catch , i will fix it

PandaeDo · 2026-09-30T05:11:34Z

+   :satisfied_by: comp__persistency_kvs[version==1]
+   :tags: inspected
+
+   When the storage cannot be loaded, the component shall behave according to the ``Need_Kvs`` configuration parameter (represented by the ``OpenNeedKvs`` flag):


General remark for all requirements:

Please use

https://eclipse-score.github.io/process_description//main/process_areas/requirements_engineering/guidance/requirements_templates.html#gd_temp__req_formulation and

https://eclipse-score.github.io/module_template/main/components/component_example/requirements/chklst_req_inspection.html

feat_req__persistency__multiple_app (ASIL_B) requires the Persistency to prevent access to a KVS instance from multiple OS processes, so this is a component requirement and not an AoU on the user. ID and wording are aligned with eclipse-score#443. Open point: the requirement is not implemented yet (Rust and C++ only use in-process mutexes, no inter-process lock). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

vinodreddy-g · 2026-10-08T12:20:58Z

+   :satisfied_by: comp__persistency_kvs[version==1]
+   :tags: inspected
+
+   The component shall access operating system services exclusively through an abstraction layer and shall not depend on any specific operating system.


isn't this sentence enough :"The component shall access operating system services exclusively through an os abstraction layer" . the second part implies the same right.

vinodreddy-g · 2026-10-08T12:24:22Z

+   :satisfied_by: comp__persistency_kvs[version==1]
+   :tags: inspected
+
+   The component shall not allocate dynamic memory during runtime operations. All memory required for runtime operation shall be allocated during initialization of a KVS instance.


Should we write it like this :"The component shall not allocate heap memory after a KVS instance has been successfully created/opened. All memory required for the instance's operation shall be allocated during its opening, with the constraints defined by :need:comp_req__kvs__constraints."

vinodreddy-g · 2026-10-08T12:27:04Z

+   :satisfied_by: comp__persistency_kvs[version==1]
+   :tags: inspected
+
+   The component shall manage all runtime variables within an instance to


Should we frame it like this :"The component shall support the concurrent existence of multiple KVS instances , such that operations on one instance do not affect the data or state of any other instance."

github-actions · 2026-10-14T21:19:52Z

Documentation preview for this pull request is available at:
pr-443: https://eclipse-score.github.io/persistency/pr-443/

PandaeDo · 2026-10-15T10:29:12Z

Suggested change

:status: invalid

resolved with latest commit

PandaeDo · 2026-10-15T10:31:51Z

-      - NO
-      - :need:`comp_req__kvs__field_mode` uses hard to verify term "as much as possible"
-      - https://github.com/eclipse-score/persistency/issues/297
+      - YES


When we change the inspection we must mark it as invalid. It's an screenshot we made with the named participants. I would recommend to keep as it is and create a new version of the inspection. There are a lot more changes that has to be considered.

resolved with latest commit

- remove tags element for all new requirements , updated requiremetns. - set status of inspection checklist to invalid

PandaeDo

Still some open topics like tag inspected for new, uninspected requirements. Fine for the moment. Safety Analysis will require update of requirements and afterwards we'll perform the inspection.

Ahmed-Elsaka-JC had a problem deploying to workflow-approval September 25, 2026 12:50 — with GitHub Actions Error

Ahmed-Elsaka-JC force-pushed the afe_update_requirements branch from 7384c86 to 12962f4 Compare September 29, 2026 12:30

Ahmed-Elsaka-JC had a problem deploying to workflow-approval September 29, 2026 12:30 — with GitHub Actions Error

Ahmed-Elsaka-JC marked this pull request as ready for review September 29, 2026 12:35

Ahmed-Elsaka-JC requested review from PandaeDo, antonkri, umaucher and vinodreddy-g as code owners September 29, 2026 12:35

PandaeDo requested changes Sep 30, 2026

View reviewed changes

Ahmed-Elsaka-JC requested a deployment to workflow-approval September 30, 2026 08:22 — with GitHub Actions Waiting

Ahmed-Elsaka-JC had a problem deploying to workflow-approval October 1, 2026 07:40 — with GitHub Actions Error

Ahmed-Elsaka-JC deployed to workflow-approval October 2, 2026 14:52 — with GitHub Actions Active

Ahmed-Elsaka-JC had a problem deploying to workflow-approval October 8, 2026 11:21 — with GitHub Actions Error

Ahmed-Elsaka-JC force-pushed the afe_update_requirements branch from d12f5f3 to 54adb90 Compare October 8, 2026 11:27

Ahmed-Elsaka-JC deployed to workflow-approval October 8, 2026 11:27 — with GitHub Actions Active

Ahmed-Elsaka-JC had a problem deploying to workflow-approval October 8, 2026 11:36 — with GitHub Actions Error

vinodreddy-g reviewed Oct 8, 2026

View reviewed changes

Ahmed-Elsaka-JC added 2 commits October 13, 2026 23:10

fix review points

30b4c65

update module bazel file

7b0782a

Ahmed-Elsaka-JC force-pushed the afe_update_requirements branch from 7800159 to 7b0782a Compare October 13, 2026 21:14

Ahmed-Elsaka-JC deployed to workflow-approval October 13, 2026 21:14 — with GitHub Actions Active

vinodreddy-g previously approved these changes Oct 14, 2026

View reviewed changes

Ahmed-Elsaka-JC requested a review from PandaeDo October 14, 2026 12:27

update snapshot requirements

78776f5

Ahmed-Elsaka-JC dismissed vinodreddy-g’s stale review via 78776f5 October 14, 2026 20:50

Ahmed-Elsaka-JC had a problem deploying to workflow-approval October 14, 2026 20:50 — with GitHub Actions Error

fix linking issues

6230491

Ahmed-Elsaka-JC deployed to workflow-approval October 14, 2026 21:11 — with GitHub Actions Active

Ahmed-Elsaka-JC requested a review from vinodreddy-g October 15, 2026 07:23

PandaeDo requested changes Oct 15, 2026

View reviewed changes

remove tags for new and updated requirements

0580055

- remove tags element for all new requirements , updated requiremetns. - set status of inspection checklist to invalid

Ahmed-Elsaka-JC deployed to workflow-approval October 15, 2026 13:06 — with GitHub Actions Active

Ahmed-Elsaka-JC requested a review from PandaeDo October 15, 2026 13:20

Merge branch 'main' into afe_update_requirements

396f692

Ahmed-Elsaka-JC had a problem deploying to workflow-approval October 15, 2026 22:12 — with GitHub Actions Error

PandaeDo approved these changes Oct 16, 2026

View reviewed changes

PandaeDo added this pull request to the merge queue Oct 16, 2026

Merged via the queue into eclipse-score:main with commit d83b0e4 Oct 16, 2026
15 of 17 checks passed

	:id: comp_req__kvs__default_value_cfg_tool_validation
	:id: comp_req__kvs__default_value_cfg_tool_vali

Conversation

Ahmed-Elsaka-JC commented Sep 25, 2026

Uh oh!

github-actions Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PandaeDo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Sep 25, 2026 •

edited

Loading