Repository navigation
Migrate coverage pipeline to score_coverage 0.3.1 - #450
Merged
Merged
Conversation
The LLVM coverage pipeline under @score_tooling//coverage moved to its own qualified module, score_coverage (eclipse-score/coverage_tool, TCL LOW). Switch the labels one-to-one, add the module as a dev dependency and set --instrumentation_filter=^//score[/:] as the 0.3.1 manual requires (Bazel's guessed filter covers only the packages of the test targets). rules_rust is already at 0.68.2-score. Scope, config, justification file and both workflows are otherwise unchanged; the README example now names the testlogs subdirectory the workflow uses. Local comparison, //score/... (5 tests), old pipeline vs this commit, LCOV compared record by record: files in report 17 -> 17 identical status 17 of 17 raw line coverage 88.09 % -> 88.09 % raw branch coverage 93.61 % -> 93.61 % kvs_helper.cpp differs in execution counts only (timing-dependent retry loop), not in covered/uncovered status. Tracking: eclipse-score/score#3258 Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
dcalavrezo-qorix
requested review from
PandaeDo,
antonkri,
umaucher and
vinodreddy-g
as code owners
September 30, 2026 06:31
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Contributor
|
LGTM |
vinodreddy-g
approved these changes
Sep 30, 2026
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollout of the qualified S-CORE coverage tool,
score_coverage0.3.1 (release notes), tracked in eclipse-score/score#3258. Linux LLVM coverage only.What
The coverage pipeline this repository used from
@score_tooling//coveragemoved to its own module. This PR switches the labels one-to-one (defs.bzl,merger,generate_coverage_htmlin both workflows, the death-test feature), addsscore_coverage0.3.1 as a dev dependency and sets--instrumentation_filter=^//score[/:]in thellvm_covconfig, as the 0.3.1 manual requires: Bazel's guessed filter covers only the packages of the test targets, and a library tested from atestsubpackage without an instrumented dependency would otherwise be compiled without counters.rules_rustis already at 0.68.2-score. Scope, justification file and workflows are otherwise unchanged; the README example now uses--testlogs-subdir score, as the workflow does.Verification
Local,
bazel coverage --config=llvm_cov //score/... --build_tests_only(5 tests), old pipeline vs this branch, LCOV compared record by record:bazel build --nobuild --lockfile_mode=error //...,bazel mod tidyscore/kvs/internal/kvs_helper.cppdiffers in execution counts only (a retry loop), not in status.New in the archive.
unmapped_files.txtlists in-scope files without any coverage data: threedeclaration-onlyheaders and twono-dataRust files,rust_kvs/src/lib.rsandrust_kvs/src/log.rs. Those two had no data before either; they were simply not listed. Worth a look by the module owners.