[karolnowak]

fixes #237
fixes #215

Description

Changes to allow a client:

• to load a selected snapshot by providing a snapshot id.
• to start an empty KVS without loading.

Usage

KvsBuilder b(instance_id);
b.snapshot(snapshot_id);
b.build();

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: ec1ccacc-0edc-4a0d-93a0-c05235405b6a
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (19 packages loaded, 14 targets configured)

Analyzing: target //:license-check (51 packages loaded, 14 targets configured)

Analyzing: target //:license-check (92 packages loaded, 14 targets configured)

Analyzing: target //:license-check (147 packages loaded, 978 targets configured)

Analyzing: target //:license-check (151 packages loaded, 3294 targets configured)

Analyzing: target //:license-check (151 packages loaded, 3294 targets configured)

Analyzing: target //:license-check (151 packages loaded, 3294 targets configured)

Analyzing: target //:license-check (164 packages loaded, 6906 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9846 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9846 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9846 targets configured)

Analyzing: target //:license-check (174 packages loaded, 15827 targets configured)

Analyzing: target //:license-check (174 packages loaded, 15827 targets configured)

Analyzing: target //:license-check (174 packages loaded, 15827 targets configured)

Analyzing: target //:license-check (175 packages loaded, 15951 targets configured)

INFO: Analyzed target //:license-check (176 packages loaded, 16077 targets configured).
[13 / 16] Generating Dash formatted dependency file ...; 0s disk-cache, processwrapper-sandbox ... (2 actions, 1 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 50 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 49.039s, Critical Path: 2.22s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
[main] INFO Querying Eclipse Foundation for license data for 42 items.
[main] INFO Found 32 items.
[main] INFO Querying ClearlyDefined for license data for 10 items.

[github-actions]

The created documentation from the pull request is available at: docu-html

[Ahmed-Elsaka-JC]

please link your PR to issue : #237

• please also provide tests to cover provided issue .

[karolnowak]

Please provide similar changes to Rust impl.

not sure if we can expect this by every contributor if @karolnowak agrees to do so fine but not everyone would feel comfortable to do both and we might need to compensate this in the feature team? If not we should make an according task to fix it "later" ... also not sure if in general should try to do always everything in 1 PR this also just makes them hard to review.

Even though I've never programmed in Rust before, it should NOT be a problem for me to make such changes in the rust version of kvs. However, I believe it is simpler to maintain two separate PRs than one large PR.
Nevertheless, it is your call whether rust changes should be here as well or in a separate PR.

Moreover, I saw that there are already discrepancies between these two implementations.
By any chance, is there an arch diagram (or sth) describing classes/API so that two implementations could conform to it, avoiding misalignment?

[arkjedrz]

Comments remain the same.
BTW add fixes #215