[arkjedrz]

• Move test scenarios to an implementation sub-directory.
• Move score_pytest calls to the implementation.
  • CIT cases are left in C++ impl - they must be placed somewhere.
    Both impls use filegroup containing test cases.
• Small visibility changes.

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: 7b5b3f27-c84d-4b6a-9c31-30b5fe3636f8
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (81 packages loaded, 14 targets configured)

Analyzing: target //:license-check (92 packages loaded, 14 targets configured)

Analyzing: target //:license-check (149 packages loaded, 1215 targets configured)

Analyzing: target //:license-check (163 packages loaded, 6249 targets configured)

Analyzing: target //:license-check (164 packages loaded, 9814 targets configured)

Analyzing: target //:license-check (167 packages loaded, 9833 targets configured)

Analyzing: target //:license-check (168 packages loaded, 9841 targets configured)

Analyzing: target //:license-check (169 packages loaded, 9850 targets configured)

Analyzing: target //:license-check (174 packages loaded, 15827 targets configured)

Analyzing: target //:license-check (175 packages loaded, 15951 targets configured)

Analyzing: target //:license-check (175 packages loaded, 15951 targets configured)

INFO: Analyzed target //:license-check (176 packages loaded, 16077 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 50 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 25.181s, Critical Path: 2.24s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
[main] INFO Querying Eclipse Foundation for license data for 42 items.
[main] INFO Found 32 items.
[main] INFO Querying ClearlyDefined for license data for 10 items.
[main] INFO Found 10 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO crate/cratesio/-/lazy_static/1.5.1
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.

[github-actions]

The created documentation from the pull request is available at: docu-html

[umaucher]

score/kvs/tests/test_scenarios/BUILD depends on //score/kvs:kvs_cpp, which is the deprecated alias for //score/kvs. It should depend on //score/kvs directly, as before this PR.

Bazel does not warn about dependencies that go through a deprecated alias. It only warns when the alias itself is built, so this goes unnoticed.

[umaucher]

dep is the deprecated alias for //score/kvs. It should depend on //score/kvs directly.

Bazel does not warn about dependencies that go through a deprecated alias. It only warns when the alias itself is built, so this goes unnoticed.