Skip to content

impl: make it possible to load a selected snapshot [rust] - #484

Merged
vinodreddy-g merged 1 commit into
eclipse-score:mainfrom
qorix-group:karolnowak-make-it-possible-to-select-snapshot-id-rust
Oct 14, 2026
Merged

vinodreddy-g merged 1 commit into
eclipse-score:mainfrom
qorix-group:karolnowak-make-it-possible-to-select-snapshot-id-rust

Conversation

@karolnowak

Copy link
Copy Markdown
Contributor

[Rust]

fixes #237
fixes #215

Description

Changes to allow a client:

  • to load a selected snapshot by providing a snapshot id.
  • to start an empty KVS without loading.

Usage

KvsBuilder b(instance_id);
b.snapshot(snapshot_id);
b.build();

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: 09754577-7a75-4b42-8ce7-17f116bcf871
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (77 packages loaded, 14 targets configured)

Analyzing: target //:license-check (140 packages loaded, 453 targets configured)

Analyzing: target //:license-check (154 packages loaded, 3278 targets configured)

Analyzing: target //:license-check (155 packages loaded, 3278 targets configured)

Analyzing: target //:license-check (156 packages loaded, 7532 targets configured)

Analyzing: target //:license-check (162 packages loaded, 9665 targets configured)

Analyzing: target //:license-check (162 packages loaded, 9665 targets configured)

Analyzing: target //:license-check (162 packages loaded, 9665 targets configured)

Analyzing: target //:license-check (163 packages loaded, 13759 targets configured)

Analyzing: target //:license-check (167 packages loaded, 15771 targets configured)

INFO: Analyzed target //:license-check (168 packages loaded, 15897 targets configured).
[3 / 14] checking cached actions
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 50 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 27.365s, Critical Path: 2.54s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
[main] INFO Querying Eclipse Foundation for license data for 42 items.
[main] INFO Found 32 items.
[main] INFO Querying ClearlyDefined for license data for 10 items.
[main] INFO Found 10 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO crate/cratesio/-/lazy_static/1.5.1
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.

@karolnowak
karolnowak force-pushed the karolnowak-make-it-possible-to-select-snapshot-id-rust branch from 5af4d50 to f2f8bc0 Compare October 9, 2026 08:03
@karolnowak
karolnowak deployed to workflow-approval October 9, 2026 08:03 — with GitHub Actions Active
@karolnowak
karolnowak deployed to workflow-approval October 9, 2026 08:03 — with GitHub Actions Active
@karolnowak
karolnowak force-pushed the karolnowak-make-it-possible-to-select-snapshot-id-rust branch from f2f8bc0 to f97c60d Compare October 9, 2026 13:26
@karolnowak
karolnowak deployed to workflow-approval October 9, 2026 13:26 — with GitHub Actions Active
@karolnowak
karolnowak deployed to workflow-approval October 9, 2026 13:26 — with GitHub Actions Active
@karolnowak karolnowak self-assigned this Oct 9, 2026
@karolnowak karolnowak added the rust Pull requests that update rust code label Oct 9, 2026
Comment thread score/kvs/rust_kvs/kvs.rs
/// Instance ID.
pub instance_id: InstanceId,

/// Snapshot ID selected during instance initialization.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be discussed if it should be there. I'm now not sure if even having defaults and kvs_load was the right call - those parameters are not really important after KVS and defaults are loaded in.

@vinodreddy-g

Copy link
Copy Markdown
Contributor

@karolnowak - could you rebase?

@karolnowak
karolnowak force-pushed the karolnowak-make-it-possible-to-select-snapshot-id-rust branch from f97c60d to 46aa48d Compare October 13, 2026 07:18
@karolnowak
karolnowak deployed to workflow-approval October 13, 2026 07:18 — with GitHub Actions Active
@karolnowak
karolnowak deployed to workflow-approval October 13, 2026 07:18 — with GitHub Actions Active
@karolnowak

Copy link
Copy Markdown
Contributor Author

@vinodreddy-g , rebased

@arkjedrz
arkjedrz force-pushed the karolnowak-make-it-possible-to-select-snapshot-id-rust branch from 46aa48d to 3880d27 Compare October 13, 2026 10:17
@arkjedrz
arkjedrz deployed to workflow-approval October 13, 2026 10:17 — with GitHub Actions Active
@arkjedrz
arkjedrz deployed to workflow-approval October 13, 2026 10:17 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-484: https://eclipse-score.github.io/persistency/pr-484/

Changes to allow a client to load a selected snapshot by providing a snapshot id.

Signed-off-by: Karol Nowak <Karol.Novak.Ext@qorix.ai>
@karolnowak
karolnowak force-pushed the karolnowak-make-it-possible-to-select-snapshot-id-rust branch from 3880d27 to ff1e23e Compare October 14, 2026 07:24
@karolnowak
karolnowak deployed to workflow-approval October 14, 2026 07:24 — with GitHub Actions Active
@karolnowak
karolnowak deployed to workflow-approval October 14, 2026 07:24 — with GitHub Actions Active
@vinodreddy-g
vinodreddy-g added this pull request to the merge queue Oct 14, 2026
Merged via the queue into eclipse-score:main with commit ba9e739 Oct 14, 2026
17 checks passed
@vinodreddy-g
vinodreddy-g deleted the karolnowak-make-it-possible-to-select-snapshot-id-rust branch October 14, 2026 08:04
@github-project-automation github-project-automation Bot moved this from Backlog to Done in PER - Persistency FT Oct 14, 2026

This branch was successfully deployed

1 active deployment
workflow-approval — ff1e23e2 Deployed Oct 14, 2026 by karolnowak via qnx-build (per-x86_64-qnx) / approval #888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improvement: Make it possible to initialize KVS when snapshot with ID=0 is not available Improvement: match three-state loading option

3 participants