Repository navigation
impl: make it possible to load a selected snapshot [rust] - #484
Merged
vinodreddy-g merged 1 commit intoOct 14, 2026
Conversation
karolnowak
requested review from
PandaeDo,
antonkri,
umaucher and
vinodreddy-g
as code owners
October 9, 2026 07:43
karolnowak
had a problem deploying
to
workflow-approval
October 9, 2026 07:44 — with
GitHub Actions
Error
karolnowak
had a problem deploying
to
workflow-approval
October 9, 2026 07:44 — with
GitHub Actions
Error
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
karolnowak
force-pushed
the
karolnowak-make-it-possible-to-select-snapshot-id-rust
branch
from
October 9, 2026 08:03
5af4d50 to
f2f8bc0
Compare
karolnowak
force-pushed
the
karolnowak-make-it-possible-to-select-snapshot-id-rust
branch
from
October 9, 2026 13:26
f2f8bc0 to
f97c60d
Compare
arkjedrz
requested changes
Oct 12, 2026
| /// Instance ID. | ||
| pub instance_id: InstanceId, | ||
|
|
||
| /// Snapshot ID selected during instance initialization. |
Contributor
There was a problem hiding this comment.
To be discussed if it should be there. I'm now not sure if even having defaults and kvs_load was the right call - those parameters are not really important after KVS and defaults are loaded in.
arkjedrz
approved these changes
Oct 12, 2026
Contributor
|
@karolnowak - could you rebase? |
karolnowak
force-pushed
the
karolnowak-make-it-possible-to-select-snapshot-id-rust
branch
from
October 13, 2026 07:18
f97c60d to
46aa48d
Compare
Contributor
Author
|
@vinodreddy-g , rebased |
arkjedrz
force-pushed
the
karolnowak-make-it-possible-to-select-snapshot-id-rust
branch
from
October 13, 2026 10:17
46aa48d to
3880d27
Compare
Contributor
|
Documentation preview for this pull request is available at: |
Changes to allow a client to load a selected snapshot by providing a snapshot id. Signed-off-by: Karol Nowak <Karol.Novak.Ext@qorix.ai>
karolnowak
force-pushed
the
karolnowak-make-it-possible-to-select-snapshot-id-rust
branch
from
October 14, 2026 07:24
3880d27 to
ff1e23e
Compare
vinodreddy-g
approved these changes
Oct 14, 2026
vinodreddy-g
deleted the
karolnowak-make-it-possible-to-select-snapshot-id-rust
branch
October 14, 2026 08:04
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Rust]
fixes #237
fixes #215
Description
Changes to allow a client:
Usage