Repository navigation
fix(rust_kvs): sync KVS and hash files to storage on flush - #489
Merged
umaucher merged 1 commit intoOct 15, 2026
Merged
Conversation
hskang-amelia
requested review from
PandaeDo,
antonkri,
umaucher and
vinodreddy-g
as code owners
October 9, 2026 12:25
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
1 of 2 tasks
Contributor
|
Documentation preview for this pull request is available at: |
JsonBackend::save wrote the KVS and hash files with fs::write, which only hands the data to the OS page cache. A power loss right after flush() could lose the data or leave the KVS and hash files out of step, so the next load fails hash validation. Write both files through a helper that calls sync_data() after the write, matching the fdatasync() the C++ Kvs::flush() got for eclipse-score#252. Signed-off-by: hskang <amelia@ivis.ai>
umaucher
force-pushed
the
fix/rust-kvs-flush-fsync
branch
from
October 14, 2026 14:01
aeed13a to
95ce1bd
Compare
umaucher
approved these changes
Oct 15, 2026
1 of 2 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonBackend::save wrote the KVS and hash files with fs::write, which only hands the data to the OS page cache. A power loss right after flush() could lose the data or leave the KVS and hash files out of step, so the next load fails hash validation.
Write both files through a helper that calls sync_data() after the write, matching the fdatasync() the C++ Kvs::flush() got for #252.