Skip to content

fix: issues related score modules and bazel caching - #12

Merged
masc2023 merged 2 commits into
mainfrom
fix_bazel_resolution
Sep 22, 2026
Merged

masc2023 merged 2 commits into
mainfrom
fix_bazel_resolution

Conversation

@FScholPer

Copy link
Copy Markdown
Contributor

Fixes multiple issues with bazel resolution

Frank Scholter Peres frank.scholter_peres@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information

Signed-off-by: Frank Scholter Peres <frank.scholter_peres@mercedes-benz.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved issues affect license overrides, fallback metadata, and component checksums.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

This PR fixes Bazel resolution and enriches generated SBOM metadata for SCORE modules.

Changes:

  • Resolves module versions using source.json.
  • Adds SCORE metadata, licenses, PURLs, and download locations.
  • Preserves default exclusions alongside custom patterns.
File Reviewed changes
tests/​test_sbom_generator.py Adds lockfile resolution regression coverage.
internal/​generator/​spdx_formatter.py Adds SCORE GitHub download locations.
internal/​generator/​sbom_generator.py Updates module resolution, metadata, licenses, and checksums.
defs.bzl Combines default and custom exclusion patterns.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread internal/generator/sbom_generator.py Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Three unresolved moderate issues remain in internal/generator/sbom_generator.py.

Review effort: Lite
Findings: None

Resolved since last review (1)

@umaucher

Copy link
Copy Markdown
Contributor

Validated locally against the real registry-pinned score_baselibs@0.2.13 (combined with persistency#430), rebuilding //:product_sbom and //:build_tools_sbom:

  • version: unknown → 0.2.13
  • license: NOASSERTION → Apache-2.0
  • checksum now populated

No regressions.

@masc2023
masc2023 merged commit fe1139d into main Sep 22, 2026
11 checks passed
@masc2023
masc2023 deleted the fix_bazel_resolution branch September 22, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants