Repository navigation
Add SPDX license metadata to generated SBOM packages #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
masc2023
merged 2 commits into
eclipse-score:main
from
umaucher:um_spdx-license-metadata
Sep 25, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,6 +46,9 @@ def generate_spdx( | |
| component_name = config.get("component_name", "unknown") | ||
| component_version = config.get("component_version", "") | ||
| producer_name = config.get("producer_name", "Eclipse Foundation") | ||
| component_license = _default_score_license( | ||
| component_name, config.get("component_license", "") | ||
| ) | ||
|
Comment on lines
+49
to
+51
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 2ebe5d0; Bazel tests pass. |
||
|
|
||
| doc_uuid = uuid.uuid4() | ||
|
|
||
|
|
@@ -62,8 +65,8 @@ def generate_spdx( | |
| "supplier": f"Organization: {producer_name}", | ||
| "primaryPackagePurpose": "APPLICATION", | ||
| "filesAnalyzed": False, | ||
| "licenseConcluded": "NOASSERTION", | ||
| "licenseDeclared": "NOASSERTION", | ||
| "licenseConcluded": component_license or "NOASSERTION", | ||
| "licenseDeclared": component_license or "NOASSERTION", | ||
| "copyrightText": "NOASSERTION", | ||
| } | ||
| packages.append(root_package) | ||
|
|
@@ -131,7 +134,7 @@ def _create_spdx_package( | |
| name = component.get("name", "unknown") | ||
| version = component.get("version", "unknown") | ||
| purl = component.get("purl", "") | ||
| license_id = _normalize_spdx_license(component.get("license", "")) | ||
| license_id = _default_score_license(name, component.get("license", "")) | ||
| description = component.get("description", "") | ||
| supplier = component.get("supplier", "") | ||
| comp_type = component.get("type", "library") | ||
|
|
@@ -185,6 +188,14 @@ def _create_spdx_package( | |
| return package, spdx_id | ||
|
|
||
|
|
||
| def _default_score_license(name: str, license_id: str) -> str: | ||
| """Use the SCORE default license when a score module has no metadata.""" | ||
| normalized = _normalize_spdx_license(license_id) | ||
| if not normalized and name.startswith("score_"): | ||
| return "Apache-2.0" | ||
| return normalized | ||
|
|
||
|
|
||
| def _map_type_to_purpose(comp_type: str) -> str: | ||
| """Map component type to SPDX 2.3 primary package purpose.""" | ||
| type_mapping = { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 2ebe5d0.