Repository navigation
fix: preserve multiple package versions in SBOM output - #19
Merged
AlexanderLanin merged 1 commit intoOct 15, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Deduplication can discard existing metadata, and mixed legacy/versioned cache selection remains order-dependent.
1 open finding
What changed in this PR
Preserves distinct package versions and version-specific Rust metadata in SBOM output.
Changes:
- Deduplicates components by name and version.
- Keys Rust cache entries and license data by
name@version. - Adds multi-version regression tests and documentation.
| File | Description |
|---|---|
internal/generator/sbom_generator.py |
Adds version-aware metadata lookup and deduplication. |
scripts/generate_crates_metadata_cache.py |
Generates version-specific Rust cache entries. |
tests/test_sbom_generator.py |
Tests multi-version SBOM generation. |
tests/test_generate_crates_metadata_cache.py |
Tests version-specific cache generation. |
README.md |
Documents multi-version behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
FScholPer
previously approved these changes
Oct 13, 2026
nicu1989
force-pushed
the
nicu1989_sbom_versions_fix
branch
from
October 14, 2026 11:41
2f7fb85 to
8b8503f
Compare
nicu1989
force-pushed
the
nicu1989_sbom_versions_fix
branch
from
October 14, 2026 12:09
8b8503f to
39b7ee4
Compare
Deduplicate components by name and version. Keep Rust cache entries and license lookups separate for each version. Require matching versions when reading older crate caches. Signed-off-by: Nicolae Dicu <nicolae.dicu.ext@qorix.ai>
nicu1989
force-pushed
the
nicu1989_sbom_versions_fix
branch
from
October 14, 2026 14:30
39b7ee4 to
cccf6ae
Compare
AlexanderLanin
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deduplicate components by name and version.
Keep Rust cache entries and license lookups separate for each version. Require matching versions when reading older crate caches.
Closes: #18