Skip to content

Add DR about module folder structure - #3194

Merged
masc2023 merged 2 commits into
mainfrom
aschemmel-tech-dr-module-folder-structure
Sep 18, 2026
Merged

Add DR about module folder structure#3194
masc2023 merged 2 commits into
mainfrom
aschemmel-tech-dr-module-folder-structure

Conversation

@aschemmel-tech

@aschemmel-tech aschemmel-tech commented Aug 19, 2026 •
edited by masc2023
Loading

Copy link
Copy Markdown
Contributor

@aschemmel-tech
aschemmel-tech marked this pull request as ready for review August 19, 2026 09:39
PandaeDo
PandaeDo previously approved these changes Aug 19, 2026
View reviewed changes
masc2023
masc2023 requested changes Aug 19, 2026
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get feedback from Communities, Feature Teams

@aschemmel-tech

ghost commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Discussed with FT's:
Baselibs: https://github.com/orgs/eclipse-score/discussions/2390#discussioncomment-18077139 (FT is already following the proposed folder structure)
Lifecycle: https://github.com/orgs/eclipse-score/discussions/2386#discussioncomment-17825050 (FT agreed to remove /src)
Persistency: FT lead agreed to remove /src as soon as we have a decision
Other FT's not affected by change as they already follow the structure (for /src): communication, logging

4og
4og previously approved these changes Aug 20, 2026
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for baselibs

MaciejKaszynski
MaciejKaszynski previously approved these changes Aug 20, 2026
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with lifecycle

LittleHuba
LittleHuba previously approved these changes Aug 20, 2026
View reviewed changes
AlexanderLanin
AlexanderLanin previously approved these changes Aug 20, 2026
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for infrastructure work either way; some sort of alignment is always preferred for us

RolandJentschETAS
RolandJentschETAS reviewed Aug 20, 2026
View reviewed changes
Comment thread docs/design_decisions/DR-003-proc.rst
Context
-------

The S-CORE project defines as part of the project's processes a `module folder structure <https://eclipse-score.github.io/score/main/contribute/general/folder.html#module-folder-structure>`_.

ghost Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link and one sentence from central folder definition in S-CORE to this DR ?

ghost Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will do

@aschemmel-tech
aschemmel-tech requested a review from a team as a code owner August 20, 2026 09:12
@github-actions

ghost commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-3194: https://eclipse-score.github.io/score/pr-3194/

@aschemmel-tech aschemmel-tech mentioned this pull request Aug 20, 2026
Merged
@umaucher umaucher mentioned this pull request Aug 21, 2026
Merged
@umaucher

ghost commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

fine for persistency ... realization in eclipse-score/persistency#386

anmittag
anmittag previously approved these changes Aug 24, 2026
View reviewed changes
a-zw
a-zw requested changes Aug 24, 2026
View reviewed changes
Comment thread docs/design_decisions/DR-003-proc.rst Outdated
@aschemmel-tech
aschemmel-tech force-pushed the aschemmel-tech-dr-module-folder-structure branch from c80bc05 to 48d4260 Compare September 18, 2026 13:04
a-zw
a-zw approved these changes Sep 18, 2026
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment was addressed.

@masc2023
masc2023 merged commit 17327bd into main Sep 18, 2026
@masc2023
masc2023 deleted the aschemmel-tech-dr-module-folder-structure branch September 18, 2026 14:59
@github-project-automation github-project-automation Bot moved this from Backlog to Done in S-CORE Roadmap Sep 18, 2026
@a-zw a-zw mentioned this pull request Sep 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-zw a-zw a-zw approved these changes
@RolandJentschETAS RolandJentschETAS RolandJentschETAS approved these changes
@masc2023 masc2023 masc2023 approved these changes
@4og 4og 4og left review comments
@AlexanderLanin AlexanderLanin AlexanderLanin left review comments
@LittleHuba LittleHuba LittleHuba left review comments
@anmittag anmittag anmittag left review comments
@MaciejKaszynski MaciejKaszynski MaciejKaszynski left review comments
@PandaeDo PandaeDo PandaeDo left review comments
@pahmann pahmann Awaiting requested review from pahmann pahmann is a code owner
@PiotrKorkus PiotrKorkus Awaiting requested review from PiotrKorkus
@MaximilianSoerenPollak MaximilianSoerenPollak Awaiting requested review from MaximilianSoerenPollak
@umaucher umaucher Awaiting requested review from umaucher

Assignees

@aschemmel-tech aschemmel-tech

Labels

None yet

Projects

S-CORE Roadmap
Status: Done
TLC - Technical Lead Circle
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.