Repository navigation
docs: Bugfix in YAML translation - #401
Merged
AlexanderLanin merged 5 commits intoFeb 18, 2025
Merged
AlexanderLanin merged 5 commits into
AlexanderLanin merged 5 commits into
Conversation
Added 'default-options' to yaml Removed 'default-options' from extra_options Added 'app' argument to checks Removed 'needs_list_types' global Ref: closes eclipse-score#396
Removed debug prints & imports Removed outcommented code which is no longer needed. Added explenation of default options Ref: closes eclipse-score#396
MaximilianSoerenPollak
force-pushed
the
MaximilianSoerenPollak_bugfix_YAML_translation
branch
from
February 17, 2025 14:31
cf936f6 to
bb25118
Compare
Contributor
|
The created documentation from the pull request is available at: docu-html |
MaximilianSoerenPollak
requested review from
AlexanderLanin,
Aymen-Soussi-01 and
nicu1989
February 17, 2025 14:33
Contributor
|
The created documentation from the pull request is available at: docu-html |
MaximilianSoerenPollak
marked this pull request as ready for review
February 17, 2025 14:33
Removed default options from yaml and moved them to separate func instead Added more comments to add context in certain parts Ref: closes eclipse-score#396
Contributor
|
The created documentation from the pull request is available at: docu-html |
Removed default_options from metamodel return Removed default_options added to config values Changed check_options to reflect new default_options Ref: closes eclipse-score#396
Contributor
|
The created documentation from the pull request is available at: docu-html |
MaximilianSoerenPollak
force-pushed
the
MaximilianSoerenPollak_bugfix_YAML_translation
branch
from
February 18, 2025 08:52
2ca1413 to
781c97c
Compare
Contributor
|
The created documentation from the pull request is available at: docu-html |
Fixed typehints of local & graph check to match new calling structure Ref: closes eclipse-score#396
MaximilianSoerenPollak
force-pushed
the
MaximilianSoerenPollak_bugfix_YAML_translation
branch
from
February 18, 2025 13:05
781c97c to
f2c0f65
Compare
Contributor
|
The created documentation from the pull request is available at: docu-html |
AlexanderLanin
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'default-options' to yaml
Removed 'default-options' from extra_options
Added 'app' argument to checks
Removed 'needs_list_types' global
Ref: closes #396
The
tests'e.g.' "check_options_test" will be fixed in coming PR's.