Skip to content

tooling: Correct Stakeholders' requirements ids to be meaningful. - #477

Merged
AlexanderLanin merged 1 commit into
eclipse-score:mainfrom
Aymen-Soussi-01:Aymen-Soussi-01-fix-build-errors-related-stkh-req
Feb 26, 2025
Merged

AlexanderLanin merged 1 commit into
eclipse-score:mainfrom
Aymen-Soussi-01:Aymen-Soussi-01-fix-build-errors-related-stkh-req

Conversation

@Aymen-Soussi-01

Copy link
Copy Markdown
Contributor

Replace all IDs of stakeholders requirements that include numbers with meaningful IDs.

Also-by: Aymen Soussi aymen.soussi@expleogroup.com

Related to: #282

@Aymen-Soussi-01
Aymen-Soussi-01 requested review from AlexanderLanin and hoe-jo and removed request for AlexanderLanin February 24, 2025 15:54
@Aymen-Soussi-01
Aymen-Soussi-01 force-pushed the Aymen-Soussi-01-fix-build-errors-related-stkh-req branch 2 times, most recently from 0624ae1 to aa3346e Compare February 24, 2025 16:03
@hoe-jo

hoe-jo commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Thanks for creating the PR, looks good. So I think we need also an exception for the "req contains feature" check for the stakeholder requirements. Can you include this change into this PR?

@Aymen-Soussi-01
Aymen-Soussi-01 force-pushed the Aymen-Soussi-01-fix-build-errors-related-stkh-req branch from aa3346e to d8247f7 Compare February 25, 2025 09:03
@Aymen-Soussi-01

Aymen-Soussi-01 commented Feb 25, 2025 •

Copy link
Copy Markdown
Contributor Author

@hoe-jo I updated the check please review it to see if it's exactly doing what you are expecting as we only have 24 remaining errors now.

@Aymen-Soussi-01
Aymen-Soussi-01 force-pushed the Aymen-Soussi-01-fix-build-errors-related-stkh-req branch 2 times, most recently from dacef95 to 32ecfde Compare February 25, 2025 09:45
@hoe-jo

hoe-jo commented Feb 25, 2025 •

Copy link
Copy Markdown
Contributor

Currently I only see 3 warnings:

fastbuild/bin/docs/_docs/_sources/docs/requirements/tool/index.rst:25: WARNING: Need 'tool_req__tool__bazel_build' has unknown outgoing link 'stkh_req__integration__int_multi_repo' in field 'satisfies' [needs.link_outgoing]

requirements/tool/index.rst:25: WARNING: tool_req__tool__bazel_build: has a parent requirement(s):
stkh_req__integration__int_multi_repo with an invalid status. [score_metamodel]

requirements/tool/index.rst:25: WARNING: tool_req__tool__bazel_build: has a valid status but one of its parents:
stkh_req__integration__int_multi_repo has an invalid status.
[score_metamodel]

And this turns out to be a false linkage the id of the stkh_req was defined as stkh_req__integration__multi_repo_

Can you please correct it?

@Aymen-Soussi-01
Aymen-Soussi-01 force-pushed the Aymen-Soussi-01-fix-build-errors-related-stkh-req branch from 32ecfde to 5406bc6 Compare February 25, 2025 14:07
@Aymen-Soussi-01

Copy link
Copy Markdown
Contributor Author

@hoe-jo I corrected the last stkh_req error. We just have 21 errors related to gd_ now

@github-actions

Copy link
Copy Markdown
Contributor

The created documentation from the pull request is available at: docu-html

Comment thread docs/requirements/stakeholder/index.rst Outdated
Comment thread docs/requirements/stakeholder/index.rst Outdated
Comment thread docs/requirements/stakeholder/index.rst Outdated
Comment thread docs/requirements/stakeholder/index.rst
Replace all IDs of stakeholders requirements and their references that include numbers with meaningful IDs.

Also-by: Aymen Soussi aymen.soussi@expleogroup.com
@Aymen-Soussi-01
Aymen-Soussi-01 force-pushed the Aymen-Soussi-01-fix-build-errors-related-stkh-req branch from 5406bc6 to e445299 Compare February 25, 2025 15:24

@hoe-jo hoe-jo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexanderLanin
AlexanderLanin merged commit ed87630 into eclipse-score:main Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants