Repository navigation
tooling: Integrate standards charts and Correct tests for checks - #550
Merged
AlexanderLanin merged 1 commit intoMar 3, 2025
Conversation
Contributor
|
The created documentation from the pull request is available at: docu-html |
Integrate the standards charts in the documentation and correct format of the tests for checks as import of metamodel. Also-by: Aymen Soussi aymen.soussi@expleogroup.com
Aymen-Soussi-01
force-pushed
the
Aymen-Soussi-01-fix-tests-and-integrate-standards-charts
branch
from
March 3, 2025 15:36
580e5e1 to
169abf7
Compare
AlexanderLanin
approved these changes
Mar 3, 2025
AlexanderLanin
left a comment
AlexanderLanin
left a comment
Member
There was a problem hiding this comment.
I think all 3 findings need to be followed up on. But let's merge this as-is, as it is an improvement as-is.
| @@ -27,7 +27,14 @@ def get_standards_needs(needs: list[NeedsInfoType]) -> dict: | |||
| return { | |||
Member
There was a problem hiding this comment.
we have a dedicated type, don't we? Something like .. standard-req::. So why do we need to differentiate by id at all?
Comment on lines
+137
to
+139
| app = Mock(spec=Sphinx) | ||
| app.config = Mock() | ||
| app.config.needs_types = self.NEED_TYPE_INFO |
Member
There was a problem hiding this comment.
We need a better testing interface. But that's out of scope of this PR.
| :labels: Connected Requirements, Not Connected Requirements | ||
| :legend: | ||
| :colors: green, red | ||
| :filter-func: _tooling.extensions.score_metamodel.checks.standards.my_pie_linked_standard_requirements |
Member
There was a problem hiding this comment.
Sound like this should not be in score_metamodel. Definitely not in checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the standards charts in the documentation and correct format of the tests for checks as import of metamodel.
Also-by: Aymen Soussi aymen.soussi@expleogroup.com
Related to: #521