Repository navigation
Adding starpls. WIP - #14
Closed
MaximilianSoerenPollak wants to merge 1 commit into
Closed
MaximilianSoerenPollak wants to merge 1 commit into
MaximilianSoerenPollak wants to merge 1 commit into
Conversation
| starpls/ | ||
| ├── BUILD | ||
| ├── MODULE.bazel | ||
| ├── MODULE.bazel.lock |
Contributor
Author
There was a problem hiding this comment.
Ahh good eye.
Will do so.
I think some files have some comments as well that should be removed.
| ├── integration_tests | ||
| │ ├── BUILD | ||
| │ ├── MODULE.bazel | ||
| │ ├── MODULE.bazel.lock |
Comment on lines
+37
to
+62
| # load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | ||
| # | ||
| # def _starpls_binary_impl(ctx): | ||
| # """Implementation of the starpls_binary rule.""" | ||
| # # Download the binary | ||
| # ctx.download( | ||
| # url = "https://github.com/withered-magic/starpls/releases/download/0.1.21/starpls-linux-amd64", | ||
| # output = "starpls", | ||
| # executable = True, | ||
| # sha256 = "45692ecb9d94a19a15b1e7b240acdff5702f78cd22188dac41e1879cb8bdcdcf", | ||
| # ) | ||
| # | ||
| # # Create a BUILD file that exposes the binary | ||
| # ctx.file("BUILD.bazel", """ | ||
| # load("@rules_shell//shell:sh_binary.bzl", "sh_binary") | ||
| # | ||
| # sh_binary( | ||
| # name = "starpls", | ||
| # srcs = ["starpls"], | ||
| # visibility = ["//visibility:public"], | ||
| # ) | ||
| # """) | ||
| # | ||
| # starpls_binary = rule( | ||
| # implementation = _starpls_binary_impl, | ||
| # ) |
Contributor
Author
There was a problem hiding this comment.
Remove, no longer needed.
Comment on lines
+30
to
+33
| local_path_override( | ||
| module_name = "score_starpls", | ||
| path = "../" | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
@dcalavrezo-qorix should this be removed once the tool is in the bazel registry?
| @@ -0,0 +1,88 @@ | |||
| import subprocess | |||
Contributor
Author
There was a problem hiding this comment.
As starpls is a language sever, testing here if it can recieve and send language server signals with the expected outcome.
| @@ -0,0 +1,8 @@ | |||
| def my_rule(): | |||
Contributor
Author
There was a problem hiding this comment.
Make it golden file input/output
Merged
Contributor
Author
|
Has been merged by #24 |
github-project-automation
Bot
moved this from Todo
to Done
in INF - Infrastructure Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.