Repository navigation
fix(repo-policy-sync): cross-repository apply - #23
Merged
Merged
Conversation
AlexanderLanin
requested review from
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
August 31, 2026 15:35
AlexanderLanin
changed the title
| f"- `{_markdown_cell(outcome.repository)}` / " | ||
| f"`{_markdown_cell(outcome.policy_id)}`: " | ||
| f"{_markdown_cell(_markdown_details(outcome))}" | ||
| f"{_markdown_cell(outcome.error or 'unknown error')}" |
Contributor
There was a problem hiding this comment.
So anything else except policy_id and repository will now not be in the markdown cell anymore.
That is wanted?
Member
Author
There was a problem hiding this comment.
yes, intentional. too much noise. link to PR is there, no need to write here what was changed.
AlexanderLanin
changed the title
MaximilianSoerenPollak
approved these changes
Sep 1, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates repo-policy-sync to work with a cross-repository bot token that has repo scope by moving certain pull-request mutations off gh pr (GraphQL) and onto gh api REST endpoints, and tightens workflow behavior around bot identity and apply-mode prerequisites.
Changes:
- Switch PR label application and PR body/title updates to
gh apiREST calls (avoidingread:orgrequirements). - Adjust markdown reporting to keep the “Details” section focused on errors only.
- Update the GitHub Actions workflow to set a global bot git identity and fail fast in apply mode when
SCORE_BOT_CLASSIC_PATis missing; update tests accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| repo_policy_sync/src/github.py | Use REST (gh api) to add PR labels and PATCH PR title/body; parse PR number from created URL. |
| repo_policy_sync/src/reporting.py | Render markdown “Details” section from error outcomes only. |
| repo_policy_sync/tests/test_github.py | Update expectations to reflect REST endpoints for labels and PR updates. |
| repo_policy_sync/tests/test_reporting.py | Update test to assert only errors appear in markdown details. |
| .github/workflows/repo-policy-sync.yml | Configure global bot author identity and require bot PAT in apply mode before running sync. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
247
to
251
| def _markdown_details_section(outcomes: tuple[RepositoryOutcome, ...]) -> list[str]: | ||
| detailed = tuple( | ||
| outcome for outcome in outcomes if _markdown_details(outcome) != "—" | ||
| ) | ||
| """Render error details without duplicating the policy pull-request list.""" | ||
|
|
||
| detailed = tuple(outcome for outcome in outcomes if outcome.error) | ||
| if not detailed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
GitHub CLI pull-request commands use GraphQL and require read:org for organization-owned repositories. The cross-repository bot deliberately has only the narrower repo scope, which is sufficient for the REST endpoints.
Verification