Repository navigation
load_main: strata-load compiles again - #12
Conversation
The arena load before this commit moved the reason into the print and signals a failure with seconds < 0; the tool still read st.ok/st.error, so the strata-load target stopped compiling (a build of the engine target alone does not notice). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
154468a to
07a2002
Compare
|
Rebased the series onto your new Still open, rebased and tested on e3727cb: #12, #13, #14, #16, #19, #20, #21. Your new
Where the difference comes from (each measured on its own, in the PRs):
|
|
One more measurement, to put the whole series in one number: your new
So the 8-21% between |
|
Thank you: merged into |
|
Thank you for merging the series, and for the fixes you made on the way ( One more thing, with no expectation attached: if any of these changes looks useful for upstream (Niko1221/Strata), |
…ts of this machine This branch is now eddoursul's `custom` (c4bcb6e: upstream 0.1.43 merged, and the engine work first done here merged on 2026-10-12 as eddoursul#12-eddoursul#16 and eddoursul#19-eddoursul#21) plus this machine's documentation: the bilingual README and MEASUREMENTS, the charts in docs/media/readme, the configs in examples/r7-5700x and examples/r9-5950x, the Spanish draft subset and the published bench/results folders. STRATA-README.md is eddoursul's current README (and STRATA-README.es.md its Spanish version); the README gains a section on custom before and after the merge, measured here on 2026-10-13. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
On
custom(e3727cb) thestrata-loadtool does not build:src/core/load_main.cppstill readsLoadStats::ok/::error, which the loader no longer has (it puts the reason in its own message and signals a failure withseconds < 0).Fix
load_mainfollows the loader's failure form. No engine code changes.gr_parityfails oncustomtoo, for another reason that is yours to decide: since the 0.1.43 merge it is upstream'stest, which checks upstream's fused-read quantization (
FusedGrArgs::q8_mixed/q8_cnt, afused_gr_read_multithat returns
bool), and this tree'sfused_grhas neither. This PR leaves it alone (this tree'sple_reader_testdoes not build either, also from the merge).Where this sits (measured today on your new
custom)customat e3727cb against our engine (your previouscustom+ this series + the upstream pieces you have mergedtoo), our configs on a Ryzen 7 5700X + 128 GB DDR4 + RTX 3090 (+ RTX 5060 Ti 16 GB), Linux.
customruns the sameconfigs without the flags it lacks (
--kv-grow,--adapt-decay,--vram-pin-gib/--second-gpu-pin-gib):custome3727cb--ple-io ram)The per-change measurements and the configs: README: what the changes on top of eddoursul's custom gave,
settings and how to run, examples/r7-5700x.
This series (rebased onto e3727cb)
Closed as already in
customafter the 0.1.43 merge: #15 (re-split GGUFs), #17 (upstream's CPU kernels), #18 (upstream fixes).Tested on
customat e3727cbEvery target that built on
customstill builds, andstrata-loadbuilds again (custom:gr_parity,ple_reader_testandstrata-loadfail; with this PR the first two).