adding string to cuckoo filter #39

Activity

1. siara-cc commented on May 13, 2023

   

   siara-cc

   on May 13, 2023

   More actions

   I faced the same issue and it looks like according to the implementation the first parameter can only be uint64_t.
   So I used following code:

   std::string mystring = "Hello World";
   cuckoofilter::CuckooFilter<size_t, 12> test(1000);
   test.Add(CityHash64(mystring.c_str(), mystring.length()));
   

   CitiHash64 can be found in src/City.h in https://github.com/aappleby/smhasher

   👍React with 👍1Reacted by Zhang Cao
2. Tom-CaoZH commented on Jul 7, 2023

   

   Tom-CaoZH

   on Jul 7, 2023

   More actions

   I wonder adding a hash function whether will impact the results(like false positive and etc) @siara-cc
3. siara-cc commented on Jul 7, 2023

   

   siara-cc

   on Jul 7, 2023

   Last edited by siara-cc

   More actions

   Hash function is the basis of such filters and so using a better hash function results in a better false positive rate. A poor hash function will have more "collisions" means the function produces same result for different input values and so will result in more false positives. @Tom-CaoZH