metricbeat/module/rabbitmq/queue: Fix data type for `consumers.utilisation.pct` by andrewkroh · Pull Request #38436 · elastic/beats

andrewkroh · 2024-03-19T18:29:07Z

Proposed commit message

Fix mapping type for rabbitmq.queue.consumers.utilisation.pct to be scaled_float instead of long because the values range on [0.0, 1.0]. Previously, truncation converted the value to an integer so it either reported zero or one.

There was a bug in the unit tests that did not catch this until we updated to testify 1.9.0 (stretchr/testify#1531). This PR removes the temporary testify v1.8.4 pin.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

    queue_test.go:58: 
        	Error Trace:	C:/Users/jenkins/workspace/PR-38346-3-4409e966-4007-43a3-9905-b28d677060d2/src/github.com/elastic/beats/metricbeat/module/rabbitmq/queue/queue_test.go:58
        	Error:      	Not equal: 
        	            	expected: float64(0.7)
        	            	actual  : int64(0)
        	Test:       	TestFetchEventContents
--- FAIL: TestFetchEventContents (0.01s)

…ation.pct Fix mapping type for `rabbitmq.queue.consumers.utilisation.pct` to be `scaled_float` instead of `long` because the values range on `[0, 1.0]`. Previously, truncation converted the value to an integer so it either reported zero or one. There was a bug in the unit tests that did not catch this until we updated to testify 1.9.0 (stretchr/testify#1531).

mergify · 2024-03-19T18:29:47Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewkroh? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Temporary fix for elastic#38436.

elasticmachine · 2024-03-19T19:23:50Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2024-03-20T01:54:36.192+0000
Duration: 183 min 36 sec

Test stats 🧪

Test	Results
Failed	0
Passed	28619
Skipped	1906
Total	30525

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

shmsr

Left one comment. Otherwise, it looks good.

…tilisation-pct

elasticmachine · 2024-03-20T02:10:37Z

💚 Build Succeeded

Buildkite Build
Commit: 8df4146

History

💚 Build #2364 succeeded fa6fa56

cc @andrewkroh

elasticmachine · 2024-03-20T02:16:03Z

💚 Build Succeeded

Buildkite Build
Commit: 8df4146

History

💚 Build #1134 succeeded fa6fa56

cc @andrewkroh

elasticmachine · 2024-03-20T02:22:50Z

💚 Build Succeeded

Buildkite Build
Commit: 8df4146

History

💚 Build #1092 succeeded fa6fa56

cc @andrewkroh

elasticmachine · 2024-03-20T02:27:31Z

💚 Build Succeeded

Buildkite Build
Commit: 8df4146

History

💚 Build #1527 succeeded fa6fa56

cc @andrewkroh

elasticmachine · 2024-03-20T02:29:47Z

💚 Build Succeeded

Buildkite Build
Commit: 8df4146

History

💚 Build #2371 succeeded fa6fa56

cc @andrewkroh

elasticmachine · 2024-03-20T02:31:54Z

💚 Build Succeeded

Buildkite Build
Commit: 8df4146

History

💚 Build #1089 succeeded fa6fa56

cc @andrewkroh

elasticmachine · 2024-03-20T02:39:29Z

💚 Build Succeeded

Buildkite Build
Commit: 8df4146

History

💚 Build #1102 succeeded fa6fa56

cc @andrewkroh

elasticmachine · 2024-03-20T02:41:43Z

💚 Build Succeeded

Buildkite Build
Commit: 8df4146

History

💚 Build #3582 succeeded fa6fa56

cc @andrewkroh

rdner · 2025-11-13T16:26:04Z

@Mergifyio backport 7.17

mergify · 2025-11-13T16:26:10Z

backport 7.17

✅ Backports have been created

Details

#47629 [7.17](backport #38436) metricbeat/module/rabbitmq/queue: Fix data type for consumers.utilisation.pct has been created for branch 7.17 but encountered conflicts

…ation.pct` (#38436) Fix mapping type for `rabbitmq.queue.consumers.utilisation.pct` to be `scaled_float` instead of `long` because the values range on `[0, 1.0]`. Previously, truncation converted the value to an integer so it either reported zero or one. There was a bug in the unit tests that did not catch this until we updated to testify 1.9.0 (stretchr/testify#1531). This PR removes the temporary testify v1.8.4 pin. (cherry picked from commit 5715699) # Conflicts: # NOTICE.txt # go.mod # metricbeat/module/rabbitmq/fields.go

…pe for `consumers.utilisation.pct` (#47629) * metricbeat/module/rabbitmq/queue: Fix data type for `consumers.utilisation.pct` (#38436) Fix mapping type for `rabbitmq.queue.consumers.utilisation.pct` to be `scaled_float` instead of `long` because the values range on `[0, 1.0]`. Previously, truncation converted the value to an integer so it either reported zero or one. There was a bug in the unit tests that did not catch this until we updated to testify 1.9.0 (stretchr/testify#1531). This PR removes the temporary testify v1.8.4 pin. (cherry picked from commit 5715699) # Conflicts: # NOTICE.txt # go.mod # metricbeat/module/rabbitmq/fields.go * Fix changelog * Resolve conflicts --------- Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> Co-authored-by: Denis <denis.rechkunov@elastic.co>

andrewkroh added bug Metricbeat Metricbeat Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Mar 19, 2024

andrewkroh requested a review from a team as a code owner March 19, 2024 18:29

botelastic Bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 19, 2024

mergify Bot assigned andrewkroh Mar 19, 2024

andrewkroh mentioned this pull request Mar 19, 2024

go.mod - bump to github.com/lestrrat-go/jwx/v2 v2.0.21 #38346

Merged

andrewkroh added a commit to andrewkroh/beats that referenced this pull request Mar 19, 2024

go.mod - Force use of github.com/stretchr/testify v1.8.4

db6fb37

Temporary fix for elastic#38436.

shmsr changed the title ~~metricbeat/module/rabbitmq/queue - Fix data type for consumers.utilsation.pct~~ metricbeat/module/rabbitmq/queue - Fix data type for consumers.utilisation.pct Mar 19, 2024

shmsr approved these changes Mar 19, 2024

View reviewed changes

Comment thread CHANGELOG.next.asciidoc Outdated

shmsr changed the title ~~metricbeat/module/rabbitmq/queue - Fix data type for consumers.utilisation.pct~~ metricbeat/module/rabbitmq/queue: Fix data type for consumers.utilisation.pct Mar 19, 2024

Merge remote-tracking branch 'elastic/main' into bugfix/mb/rabbitmq-u…

67f93de

…tilisation-pct

andrewkroh requested a review from a team as a code owner March 20, 2024 01:37

andrewkroh added 2 commits March 19, 2024 21:54

go.mod - remove temporary pinning of testify dep

c9558a0

improve changelog

8df4146

andrewkroh force-pushed the bugfix/mb/rabbitmq-utilisation-pct branch from 8c82f16 to 8df4146 Compare March 20, 2024 01:54

This comment was marked as outdated.

Sign in to view

cmacknz approved these changes Mar 20, 2024

View reviewed changes

andrewkroh merged commit 5715699 into elastic:main Mar 20, 2024

rdner added the backport-7.17 Automated backport to the 7.17 branch with mergify label Nov 13, 2025

mergify Bot mentioned this pull request Nov 13, 2025

[7.17](backport #38436) metricbeat/module/rabbitmq/queue: Fix data type for consumers.utilisation.pct #47629

Merged

1 of 6 tasks

Conversation

andrewkroh commented Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed commit message

Checklist

Related issues

Logs

Uh oh!

mergify Bot commented Mar 19, 2024

Uh oh!

elasticmachine commented Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

Uh oh!

shmsr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

elasticmachine commented Mar 20, 2024

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Mar 20, 2024

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Mar 20, 2024

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Mar 20, 2024

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Mar 20, 2024

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Mar 20, 2024

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Mar 20, 2024

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Mar 20, 2024

💚 Build Succeeded

History

Uh oh!

rdner commented Nov 13, 2025

Uh oh!

mergify Bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

andrewkroh commented Mar 19, 2024 •

edited

Loading

elasticmachine commented Mar 19, 2024 •

edited

Loading

mergify Bot commented Nov 13, 2025 •

edited

Loading