Skip to content

Grant release-eng build access to connectors pipeline - #4004

Merged
Apmats merged 2 commits into
mainfrom
am/grant-release-eng-build-access
May 6, 2026
Merged

Apmats merged 2 commits into
mainfrom
am/grant-release-eng-build-access

Conversation

@Apmats

@Apmats Apmats commented May 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds release-eng: BUILD_AND_READ to the connectors pipeline's teams block so release-eng team members can trigger builds.

Why

The connectors-version-bump pipeline (introduced in #3986) executes a trigger: step that starts a DRA build on the target release branch on the main connectors pipeline. Buildkite propagates the original triggering user's identity through trigger chains, so the downstream build on connectors is created as that user -- and the user needs Build access on connectors for the trigger to succeed.

We already granted release-eng BUILD_AND_READ on connectors-version-bump (so they can trigger our pipeline at all), but missed adding it on the main connectors pipeline. This caused failures in build #3 (9.3.5) and build #4 (8.19.16) when triggered by Nina Lee, while build #2 (9.4.1) triggered by Julien Mailleret succeeded -- presumably via individual grants.

This grants team-level access so any release-eng member can complete the version bump end-to-end.

Test plan

The version bump pipeline triggers a DRA build on the target release
branch via a `trigger:` step. Buildkite propagates the original user's
identity through trigger chains, so when release-eng triggers the
centralized version bump pipeline, the eventual build on `connectors`
is created as that user.

release-eng was already granted BUILD_AND_READ on connectors-version-bump,
but missing on the main connectors pipeline, causing the trigger to fail
for users without direct individual grants. This adds team-level access
so any release-eng member can complete the version bump flow.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Apmats
Apmats requested a review from a team as a code owner May 6, 2026 13:30

@lorenabalan lorenabalan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apmats
Apmats enabled auto-merge (squash) May 6, 2026 13:53
@Apmats
Apmats merged commit 8c1138c into main May 6, 2026
2 checks passed
@Apmats
Apmats deleted the am/grant-release-eng-build-access branch May 6, 2026 14:06
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

💔 Failed to create backport PR(s)

Status Branch Result
❌ 9.5 The branch "9.5" is invalid or doesn't exist

To backport manually run:
backport --pr 4004 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants