Conversation
Address two Snyk vulnerability findings in dev/CI-only Python tooling: - sentencepiece: floor-pin to >=0.2.1 to pull in the fix for CVE-2026-1260 (SNYK-PYTHON-SENTENCEPIECE-15091567), a heap overflow when parsing a malicious precompiled normalization model. - zipp: add an explicit floor pin >=3.19.1 (it is a transitive dep of the dev-tools pytest suite) for CVE-2024-5569 (SNYK-PYTHON-ZIPP-7430899), an infinite-loop DoS on malformed zip paths. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves two Snyk vulnerability findings in dev/CI-only Python tooling (not shipped in the product):
sentencepiece(dev-tools/extract_model_ops/requirements.txt): floor-pin>=0.2.0→>=0.2.1to pull in the fix for CVE-2026-1260 (SNYK-PYTHON-SENTENCEPIECE-15091567) — a heap-based buffer overflow when parsing a malicious precompiled normalization model.zipp(dev-tools/test-requirements.txt): add an explicit floor pin>=3.19.1for CVE-2024-5569 (SNYK-PYTHON-ZIPP-7430899) — an infinite-loop DoS on malformed zip paths.zippis a transitive dependency of thedev-tools/unittestpytest suite (viaimportlib.metadata), so a direct floor pin is used to guarantee the patched version.Both findings surfaced in the Snyk Open Source reports for
elastic/ml-cpp. These are the only two Snyk Open Source findings for this repo; the remaining ~925 findings are Snyk Container findings against the base OS packages of the dev/build Docker images, which are handled separately via base-image refreshes.Test plan
pip install -r dev-tools/test-requirements.txtresolveszippto a patched version (4.1.0 ≥ 3.19.1).dev-tools/unittestpytest suite passes (95 passed, 3 skipped — the torch/transformers-gatedextract_model_opsconfig tests): mirrors CI's.buildkite/scripts/steps/dev_tools_pytest.sh.sentencepiecepin installs and imports cleanly (resolves to ≥ 0.2.1). Note: no offline test exercisessentencepiecedirectly (it is a lazy runtime dep oftransformerstokenizers that requires a model download), so this is an install/import sanity check.Made with Cursor