Skip to content

fix(dremio): add +root_path to e2e project to fix CI with dbt-dremio 1.10.1 - #2275

Merged
elazarlachkar merged 1 commit into
masterfrom
fix/dremio-e2e-root-path
Jun 21, 2026
Merged

fix(dremio): add +root_path to e2e project to fix CI with dbt-dremio 1.10.1#2275
elazarlachkar merged 1 commit into
masterfrom
fix/dremio-e2e-root-path

Conversation

@elazarlachkar

@elazarlachkar elazarlachkar commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Problem

`dbt-dremio` 1.10.1 introduced a breaking change in TABLE schema resolution: it now uses `+root_path` instead of `+schema` for table materializations. Without `+root_path` set, tables fall back to `target.root_path` directly — ignoring `+schema` entirely.

In the e2e test project, `elementary` models had `+schema: elementary` but no `+root_path`. After the implicit upgrade to 1.10.1 in CI, tables started landing at `elementary_tests` instead of `elementary_tests.elementary`. The CLI's `elementary` profile hardcodes `enterprise_catalog_folder: elementary_tests.elementary`, so `alerts_v2` couldn't find `test_result_rows` → "Object not found" error.

This only affects CI. Real users are unaffected because `edr generate-profile-yml` reads the actual compiled graph and writes the correct path into the `elementary` profile automatically.

Note for Dremio users upgrading to dbt-dremio 1.10.1: if you upgrade without adding `+root_path: elementary` to your project, your Elementary tables will move from `my_schema.elementary` to `my_schema`. Re-running `edr generate-profile-yml` after upgrading will regenerate your `elementary` profile to point at the new location. Alternatively, adding `+root_path: elementary` to your `dbt_project.yml` (as done here) keeps tables at `my_schema.elementary` in both versions and avoids the need to regenerate.

Fix

Add `+root_path: elementary` to the e2e project's `dbt_project.yml`.

  • In 1.10.1: `+root_path` takes precedence for TABLE nodes → tables land at `elementary_tests.elementary` ✓
  • In 1.10.0: `+root_path` is unused, `+schema` still drives table resolution → tables land at `elementary_tests.elementary` ✓

Both versions now agree with the CLI profile's hardcoded `elementary_tests.elementary`.

…1.10.1

dbt-dremio 1.10.1 changed TABLE schema resolution to use +root_path instead of +schema. Without +root_path set, tables fall back to target.root_path directly, landing at 'elementary_tests' instead of 'elementary_tests.elementary'. The CLI profile hardcodes 'elementary_tests.elementary', causing 'object not found' errors. Adding +root_path: elementary makes tables land at the same path in both 1.10.0 and 1.10.1.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown
Contributor

👋 @elazarlachkar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

A single line is added to tests/e2e_dbt_project/dbt_project.yml, setting +root_path: elementary under the models.elementary_integration_tests.elementary configuration block alongside the existing file_format setting.

Changes

elementary model root_path config

Layer / File(s) Summary
Add +root_path to elementary model config
tests/e2e_dbt_project/dbt_project.yml
Adds +root_path: elementary under the models.elementary_integration_tests.elementary config block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A single line hops into place,
root_path: elementary joins the race.
The YAML field sits snug and neat,
One tiny tweak, the config's complete.
🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and specifically describes the main change: adding +root_path to fix CI compatibility with dbt-dremio 1.10.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dremio-e2e-root-path

Comment @coderabbitai help to get the list of available commands and usage tips.

@elazarlachkar elazarlachkar self-assigned this Jun 21, 2026
@elazarlachkar
elazarlachkar merged commit 6722a17 into master Jun 21, 2026
27 checks passed
@elazarlachkar
elazarlachkar deleted the fix/dremio-e2e-root-path branch June 21, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants