Internal: Add Upgrade to Pro button in Hello Theme top bar [TMZ-1067] - #680
Open
Ntnelbaba wants to merge 8 commits into
Open
Internal: Add Upgrade to Pro button in Hello Theme top bar [TMZ-1067]#680Ntnelbaba wants to merge 8 commits into
Ntnelbaba wants to merge 8 commits into
Conversation
The Hello Theme Home screen and its Upgrade to Pro banner were removed, leaving no upgrade CTA in the admin. Add one to the settings top bar, reusing the go.elementor.com/hello-upgrade-epro link the banner used. The upgrade URL is only localized when Elementor Pro is inactive, so the Pro check stays in PHP and the button renders from the config alone. Wrap the top bar root in the Elementor UI ThemeProvider, matching the settings and conversion banner entries. Without it the tree falls back to the default MUI theme, which has no promotion palette entry. Ref: TMZ-1067 Co-authored-by: Cursor <cursoragent@cursor.com>
davseve
previously approved these changes
Aug 16, 2026
The Hello menu item already redirects to the settings page, so the Settings submenu entry was the only item in the flyout and duplicated that destination. Hide it with remove_submenu_page, which only unsets the display entry and leaves the page registered. The settings URL keeps working for existing links, the Finder entry, and the screen ID that gates the settings script enqueue. Ref: TMZ-1067 Co-authored-by: Cursor <cursoragent@cursor.com>
…-1067] Removing the submenu entry during admin_menu made the settings page return "Sorry, you are not allowed to access this page". WordPress resolves a plugin page's hook through get_admin_page_parent, which finds the parent by scanning the submenu globals. admin.php builds the menu before it resolves the hook, so the entry was already gone and the lookup failed. Move the removal to admin_head, which runs after the hook is resolved and before menu-header.php renders the sidebar. Ref: TMZ-1067 Co-authored-by: Cursor <cursoragent@cursor.com>
Hello Elementor BuildLast updated at: 20260816.1434 ✅ Hello Elementor build is ready for download. You can download the latest build from the link below: The build is available for 7 days. |
…:elementor/hello-theme into internal/TMZ-1067-upgrade-to-pro-top-bar
davseve
reviewed
Aug 16, 2026
davseve
previously approved these changes
Aug 16, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removing the Hello Theme Home screen also removed the Upgrade to Pro banner, leaving no upgrade CTA in the admin. This adds one to the Hello settings top bar, reusing the same
go.elementor.com/hello-upgrade-eprolink the old banner used.Admin_Top_Barlocalizes the upgrade URL only when Elementor Pro is inactive, so the Pro check lives in PHP and the React side just renders whatever config it is given.UpgradeButtonrendersUpgrade NowwithCrownIconandcolor="promotion", matching how Core styles its own admin top bar upgrade CTA.ThemeProvider, matching the settings and conversion banner entries. Without it the tree falls back to the default MUI theme, which has nopromotionpalette entry, so the button did not paint.Jira
TMZ-1067
Test plan
admin.php?page=hello-elementor-settingsand confirm the crown +Upgrade Nowbutton appears at the right of the top barhttps://go.elementor.com/hello-upgrade-epro/and opens in a new tabwindow.ehpTopBarConfigis not definedHellobranding and top bar layout are unchanged in both light and dark admin color schemesMade with Cursor
✨ PR Description
1. Problem & Context
Adding "Upgrade to Pro" button to Hello Theme admin top bar for users without Elementor Pro, reducing friction to upgrade path. Ticket: TMZ-1067.
2. What Changed (Where)
admin_head3. How It Works
TopBar mounts on
DOMContentLoaded→ renders UpgradeButton ifwindow.ehpTopBarConfig.upgradeUrlexists → PHP conditionally localizes script data only for non-Pro users viaUtils::has_pro()check. Settings submenu hidden via separateadmin_headaction hook (avoids page hook resolution issues fromadmin_menu).4. Risks
Config object accessed directly from window without type safety; gracefully handles missing data but depends on script localization executing. ThemeProvider wrapping adds dependency on Elementor UI theme consistency.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how