Skip to content

Fix test\runner sanity.test_aaa_normal to work on Windows #19375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juj merged 1 commit into from
Aug 30, 2024
Merged

Fix test\runner sanity.test_aaa_normal to work on Windows #19375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/test_sanity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

from common import RunnerCore, path_from_root, env_modify, test_file
from common import create_file, ensure_dir, make_executable, with_env_modify
from common import parameterized, EMBUILDER
from common import crossplatform, parameterized, EMBUILDER
from tools.config import EM_CONFIG
from tools.shared import EMCC
from tools.shared import config
Expand All @@ -26,7 +26,7 @@
from tools import ports

SANITY_FILE = cache.get_path('sanity.txt')
commands = [[EMCC], [path_from_root('test/runner'), 'blahblah']]
commands = [[EMCC], [shared.bat_suffix(path_from_root('test/runner')), 'blahblah']]
expected_llvm_version = str(shared.EXPECTED_LLVM_VERSION) + '.0.0'


Expand Down Expand Up @@ -156,6 +156,7 @@ def check_working(self, command, expected=None):
return output

# this should be the very first thing that runs. if this fails, everything else is irrelevant!
@crossplatform
def test_aaa_normal(self):
for command in commands:
# Your existing EM_CONFIG should work!
Expand Down