Skip to content

[test] Allow --crossplatform-only to include sanity tests - #22492

Merged
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:crossplatform_sanity
Sep 3, 2024
Merged

sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:crossplatform_sanity

Conversation

@sbc100

@sbc100 sbc100 commented Sep 3, 2024

Copy link
Copy Markdown
Collaborator

See #19375

@sbc100
sbc100 requested review from juj and kripken September 3, 2024 18:11
@juj

juj commented Sep 3, 2024 •

Copy link
Copy Markdown
Collaborator

Did the @crossplatform directive I added get ignored without this? LGTM

@sbc100
sbc100 force-pushed the crossplatform_sanity branch from 05a026a to 48cd119 Compare September 3, 2024 19:07
@sbc100

sbc100 commented Sep 3, 2024

Copy link
Copy Markdown
Collaborator Author

Did the @crossplatform directive I added get ignored without this? LGTM

yes, the --crossplatform-only flag (and thus the attribute that controls it) was previously only used for core0 and other tests.

@sbc100
sbc100 merged commit 3e76938 into emscripten-core:main Sep 3, 2024
@sbc100
sbc100 deleted the crossplatform_sanity branch September 3, 2024 21:23
sbc100 added a commit that referenced this pull request Sep 1, 2026
Sanity tests previously ran on Windows via `--crossplatform-only` after
#22492, but were removed in #26365 when all tests were combined into a
single parallel test suite (which made mixing parallel and non-parallel
modules an error).

Run `sanity.test_windows_path_casing` as a dedicated step in
`test-windows` so the Windows path casing regression test from #27626 is
exercised in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants