Repository navigation
chore: update k8s.io to v0.27.1 - #1326
Merged
Merged
Conversation
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
added 2 commits
April 18, 2023 19:04
This was referenced Apr 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #1326 +/- ##
==========================================
- Coverage 61.81% 61.74% -0.07%
==========================================
Files 85 85
Lines 10854 10854
==========================================
- Hits 6709 6702 -7
- Misses 3700 3706 +6
- Partials 445 446 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Apr 18, 2023
| } | ||
|
|
||
| func (r *gatewayAPIReconciler) enqueueManagedClass(obj client.Object) []reconcile.Request { | ||
| func (r *gatewayAPIReconciler) enqueueManagedClass(_ context.Context, obj client.Object) []reconcile.Request { |
Contributor
There was a problem hiding this comment.
curious why this API signature had to change ?
Member
Author
There was a problem hiding this comment.
arkodg
approved these changes
Apr 19, 2023
qicz
reviewed
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
chore: update k8s.io to v0.27.1
Which issue(s) this PR fixes:
Fixes #