feat: nitro-rpc proto and golang draft implementation - #2
Merged
Conversation
nksazonov
reviewed
Mar 13, 2025
nksazonov
approved these changes
Mar 14, 2025
|
|
||
| state := RPCState{ | ||
| RequestID: req.Req.GetRequestId(), | ||
| Timestamp: req.Req.GetTimestamp(), |
There was a problem hiding this comment.
Shouldn't we set a new timestamp here, so that an external party can calculate how much time a response took place to calculate?
Author
There was a problem hiding this comment.
As I discussed with @mnaichuk timestamp will be later generated by server, so that is TBD
|
|
||
| privateKey, err := crypto.GenerateKey() | ||
| require.NoError(t, err) | ||
| ss := signer.NewLocalSigner(privateKey) |
Author
There was a problem hiding this comment.
Because signer is the name of the package, and ss stands for stateSigner, I could instead use rename for package as signer_pkg
nksazonov
approved these changes
Mar 14, 2025
mod
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.