Skip to content

docs: use the same option format on the get-by-prefix and save-database pages - #1232

Open
ThatDeparted2061 wants to merge 1 commit into
etcd-io:mainfrom
ThatDeparted2061:fix-option-lines
Open

ThatDeparted2061 wants to merge 1 commit into
etcd-io:mainfrom
ThatDeparted2061:fix-option-lines

Conversation

@ThatDeparted2061

Copy link
Copy Markdown

Fixes #1212

The get-keys-by-prefix and save-database pages wrote their options as --endpoints=[127.0.0.1:2379], gRPC endpoints, so the comma looks like part of the command. The other task pages (watch, delete, check cluster status) already use --flag: description, so this switches these two pages to that form:

--endpoints="127.0.0.1:2379": gRPC endpoints
--prefix[=false]: get a range of keys with matching prefix

Same change in v3.5, v3.6, v3.7 and v3.8 (12 lines, no other content changes).

…se pages

These two pages wrote options as "--endpoints=[127.0.0.1:2379], gRPC endpoints", which reads as if the comma is part of the command. Use the "--flag: description" form that the other task pages already use.

Signed-off-by: ThatDeparted2061 <harshraocodesup@gmail.com>
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ThatDeparted2061
Once this PR has been reviewed and has the lgtm label, please assign wendy-ha18 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

Copy link
Copy Markdown

Hi @ThatDeparted2061. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jberkus

jberkus commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Surprised by a comma?

2 participants