Repository navigation
Improve "How to get keys by prefix" task page - #1248
namrathatiptur wants to merge 1 commit into
Conversation
Signed-off-by: namrathatiptur <namrathatm2018@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: namrathatiptur The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @namrathatiptur. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
Looks good, going to wait for Prow to clear before I try to merge. |
Don't worry about that, 3.5 will be EOL in may, we don't need to backport. |
|
/retest |
Fixes #1247
What this changes
Rewrites the "How to get keys by prefix" task page, as requested in the issue:
/registry/pods/<namespace>/<name>) to show how prefixes work like folders.clientv3.WithPrefix(), with the setup steps (go mod init,go get,go run) so it can be run as-is.I also added:
/registry/pods/defaultalso matches/registry/pods/default-staging/..., which is an easy mistake to make.export ENDPOINTS=...step, since the page uses$ENDPOINTSbut never set it.etcdctl get --help).Versions
v3.5/tutorials/how-to-get-key-by-prefix.md, because v3.5 uses a different layout. Happy to do it in a follow-up if wanted.Notes for reviewers
textblocks instead of in the same block as the command. I did this so the commands can be copied without the output. Happy to switch to the style used on the other pages if you prefer.Testing
go.etcd.io/etcd/client/v3v3.7.3.go vetpasses.markdownlint-cli2passes on all three files.hugo serve.