Skip to content

Maven? #97

Open
Open

Description

@fsiler

Would this project be inclined to accept PRs related to Mavenization? I'm just getting started with Java build tools and want to play with jstylo, so this seems like a worthy start. Thanks for any advice.

Activity

  1. mvryan commented on Jan 12, 2017

    @mvryan
    Member

    Hi, Frank. Thank you for the interest and offer of help.

    I do want to let you know that Mavenising JGAAP would not help jStylo. They depend on the version 5 line of JGAAP and have modified it internally. JGAAP's internal API has changed significantly in since that time to allow the use of multiple EventDrivers each with their own Canonicizers and Cullers. I'm not sure if the psal at Drexel has ever published the modified source of JGAAP but that is what you would want to get up on Maven to simply the build process.

    If you are still interested in helping us by updating JGAAP to use Maven, we would be happy to review any pull request.

    Just to let you know the biggest thing holding back a proper 7.0 release of JGAAP is UI work if you're interested in that.

    Best,
    Mike

  2. fsiler commented on Jan 13, 2017

    @fsiler
    Author

    Sure, jstylo needs some work in other areas- for one, using reflection would be nice :). Let me dig in a bit and see where the pain comes up, and hopefully I can send a couple useful patches your way. Many thanks.

    Frank

  3. added a commit that references this issue on Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions