Do not send the default port in the Host header - #485
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing an HTTPS site (e.g.
expose share https://mysite.testorherd shareon a secured site) sentHost: mysite.test:443to the local app. WordPress treats that as a non-canonical URL and answers every request with a 301 to the local domain, so the tunnel was unusable. For the same reason,Locationheaders were never rewritten for HTTPS shares, because the redirect targetmysite.testdoes not containmysite.test:443.The
Hostheader is now taken from the request URI, which omits the default port of its scheme, andLocationmatching ignores the:443that Expose appends itself.Why this does not break other setups:
:8443,localhost:8080) are kept in theHostheader and still rewritten inLocation.🤖 Generated with Claude Code