reject non-comparable keys in fromPairs#964
Open
netliomax25-code wants to merge 1 commit into
Open
Conversation
Author
|
gentle ping |
sanmaxdev
reviewed
Jul 14, 2026
sanmaxdev
left a comment
sanmaxdev
left a comment
There was a problem hiding this comment.
Verified that fromPairs now returns a descriptive error for slice keys instead of panicking.
Checks passed:
go test ./...go test -race .go test -tags=expr_debug -run=TestDebugger -v ./vmGOARCH=386 go buildgit diff --check origin/master...HEAD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fromPairs builds a map[any]any, so a pair whose key is a slice or
map hits a raw "hash of unhashable type" runtime panic. Check the
key is comparable before SetMapIndex and return an error instead,
matching the groupBy handling added in #940.