Skip to content

fix(urlencoded): prevent 32-bit integer overflow in parameterLimit #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
helmipradita wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(urlencoded): prevent 32-bit integer overflow in parameterLimit #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/types/urlencoded.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function createQueryParser (options) {
}

if (isFinite(parameterLimit)) {
parameterLimit = parameterLimit | 0
parameterLimit = Math.trunc(parameterLimit)
}

return function parse (body, encoding) {
Expand Down
16 changes: 16 additions & 0 deletions test/urlencoded.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,14 @@ describe('bodyParser.urlencoded()', function () {
.expect(200, done)
})

it('should work with limit greater than 32-bit signed integer', function (done) {
request(createServer({ extended: false, parameterLimit: 3000000000 }))
.post('/')
.set('Content-Type', 'application/x-www-form-urlencoded')
.send('user=tobi')
.expect(200, '{"user":"tobi"}', done)
})

it('should work with Infinity limit', function (done) {
request(createServer({ extended: false, parameterLimit: Infinity }))
.post('/')
Expand Down Expand Up @@ -572,6 +580,14 @@ describe('bodyParser.urlencoded()', function () {
.expect(200, done)
})

it('should work with limit greater than 32-bit signed integer', function (done) {
request(createServer({ extended: true, parameterLimit: 3000000000 }))
.post('/')
.set('Content-Type', 'application/x-www-form-urlencoded')
.send('user=tobi')
.expect(200, '{"user":"tobi"}', done)
})

it('should work with Infinity limit', function (done) {
request(createServer({ extended: true, parameterLimit: Infinity }))
.post('/')
Expand Down